Generic Stack Array

Question

I have to implement a generic stack, but when I try to build the project I have an error that I can't figure out. Here's the code:

Stack.java -> interface

package stack;

public interface Stack <T> {
    public boolean isEmpty();
    public boolean isFull();
    public void push(T x) throws StackFullException;
    public boolean offer(T x);
    public T pop() throws StackEmptyException;
    public T poll();
    public T peek() throws StackEmptyException;
    public T element();
}

StackArray.java -> the implementation of the interface

package stack;

public class StackArray <T extends Number> implements Stack {
    static int max;
    private int nr;
    private T[] stack;

    public StackArray(int size){
        nr=0;
        stack=(T[])(new Object[size]);
        max=size;
    }
    public boolean isEmpty() {
        if (nr<=0)
            return true;
        return false;
    }
    public boolean isFull() {
        if (nr==max-1)
            return true;
        return false;
    }
    public void push(Object x) throws StackFullException{
        if(isFull())
            throw new StackFullException();
        else
            stack[nr++]=(T)x;
    }
    public boolean offer(Object x) {
        if(isFull())
            return false;
        else
        {
            stack[nr++]=(T)x;
            return true;
        }
    }

    public T pop() throws StackEmptyException {
        T aux=(T)(new Object());
        if(isEmpty())
            throw new StackEmptyException();
        else
            {
                aux=stack[nr];
                stack[nr]=null;
                nr--;
                return aux;
            }
        }

    public T poll() {
        T aux=(T)(new Object());
        if(isEmpty())
            return null;
        else
        {
             aux=stack[nr];
             stack[nr]=null;
             nr--;
             return aux;
        }

    }

    public T peek() throws StackEmptyException {
        if(isEmpty())
            throw new StackEmptyException();
        else
            return stack[nr];
    }

    public T element() {
        if(isEmpty())
            return null;
        else
            return stack[nr];
    }

}

And the main class:

package stack;

public class Main {
    public static void main(String[] args) throws StackFullException, StackEmptyException {
        StackArray stiva=new StackArray(10);
        for(int i=1; i<10; i++)
            stiva.push(i);
        for(int i=1; i<10; i++)
            System.out.print(stiva.pop()+" ");
    }

}

When I try to build the project I receive the following error:

Exception in thread "main" java.lang.ClassCastException: [Ljava.lang.Object; cannot be cast to [Ljava.lang.Number;
        at stack.StackArray.<init>(StackArray.java:10)
        at stack.Main.main(Main.java:5)
Java Result: 1

Can anyone help me? Thanks!

Any particular reason you don't want to use [Stack][1] or an implementation of [Deque][2]? [1]: download.oracle.com/javase/6/docs/api/java/util/Stack.html [2]: download.oracle.com/javase/6/docs/api/java/util/Deque.html — Peter Knego
– Peter Knego, Commented Mar 14, 2011 at 1:09
One other thing; there doesn't seem to be a good reason for max to be null; in fact, your code will probably fail pretty catastrophically if people use two instances of your stack at once. — Mark Peters
– Mark Peters, Commented Mar 14, 2011 at 1:59

Mark Peters · Accepted Answer · 2011-03-13 23:19:01Z

3

The erasure of T[] is Number[] because the upper bound of T is Number. Thus your stack is really declared as a Number[] not an Object[]. In your constructor you are trying to assign an Object[] to stack. Create a Number[] instead.

stack=(T[])(new Number[size]);

As an aside, you probably want

public class StackArray <T extends Number> implements Stack<T>

You shouldn't implement the raw version of the class. As a consequence you'll need to update other methods (e.g. push(T) instead of push(Object)).

edited Mar 13, 2011 at 23:19

answered Mar 13, 2011 at 23:13

Mark Peters

81.3k17 gold badges164 silver badges196 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Ionut Ungureanu Over a year ago

I've made those changes and now I have the following error: Exception in thread "main" java.lang.ClassCastException: java.lang.Object cannot be cast to java.lang.Number at stack.StackArray.pop(StackArray.java:40) at stack.Main.main(Main.java:9) Java Result: 1 Line 40 is T aux=(T)(new Object());

Peter Knego Over a year ago

Why do you try to create a new object and then reassign the variable? Jus do T aux; - no need to initialize it (not mentioning that it's wrong).

Mark Peters Over a year ago

@Ionut: @Peter is right. There is absolutely no reason you need to create an object there.

Ionut Ungureanu Over a year ago

@Peter Knego: Thanks! That was the problem. I've changed to simple T aux and worked. Problem solved!

Peter Knego Over a year ago

@Ionut: any reason you don't want to use Stack or ArrayDeque provided by Java?

|

rich · Accepted Answer · 2011-03-13 23:12:38Z

0

Try changing line 5 of Main.java to be:

StackArray<Integer> stiva = new StackArray<Integer>(10);

(Or some other type that extends Number, as required where you've marked StackArray as ).

answered Mar 13, 2011 at 23:12

rich

19.5k11 gold badges80 silver badges105 bronze badges

Comments

brimborium · Accepted Answer · 2012-11-13 10:20:22Z

0

Change

public void push(Object x)

to

public void push(Number x) //or T

edited Nov 13, 2012 at 10:20

brimborium

9,56210 gold badges50 silver badges77 bronze badges

answered Mar 13, 2011 at 23:14

Scott

17.1k16 gold badges83 silver badges123 bronze badges

Collectives™ on Stack Overflow

Generic Stack Array

3 Answers 3

6 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

6 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related