Error implementing Custom Validation in Laravel

Question

I am trying to add an extra validation rule that checks to ensure that a username is a word. I created a new rule (SingleWord) like so:

public function passes($attribute, $value)
    { 
        $dd =  strpos(trim($value), ' ');
        if($dd !== false){
            return false;
        }
    }

    /**
     * Get the validation error message.
     *
     * @return string
     */
    public function message()
    {
        return 'Username must be one word';
    }

I now added this rule to the validator like so:

 $validator =  Validator::make($data, [
            'name' => 'required|string|max:255|unique:merchants',
            'email' => 'required|string|email|max:255|unique:merchants',
            'password' => 'required|string|min:6',
            'username' => 'required|string|unique:merchants',
            'username' => [new SingleWord]
        ],[
            'name.required' => "Company name is required",
        ]);
        return $validator;

But the validator returns the error message even when I enter one word. Please what might be wrong here?

It might be that you're not explicitly returning true from function passes(). The default return value if you don't return something is null which might be evaluating to false. — ourmandave
– ourmandave, Commented Oct 28, 2018 at 22:09

Elisha Senoo · Accepted Answer · 2018-10-28 23:28:57Z

2

You left out the affirmative case. Try this:

public function passes($attribute, $value)
    { 
        $dd =  strpos(trim($value), ' ');
        if($dd !== false){
            return false;
        }
        return true; 
    }

    /**
     * Get the validation error message.
     *
     * @return string
     */
    public function message()
    {
        return 'Username must be one word';
    }

answered Oct 28, 2018 at 23:28

Elisha Senoo

3,6092 gold badges24 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

nakov · Accepted Answer · 2018-10-28 22:10:55Z

1

Without knowing your error message, I will suggest couple of changes, first in your validation you can change your passes method to this:

public function passes($attribute, $value)
{ 
    return !strpos(trim($value), ' ');
}

and then your validation, you can use only one key like this:

'username' => ['required', 'string', 'unique:merchants' , new SingleWord]

answered Oct 28, 2018 at 22:10

nakov

14.4k14 gold badges74 silver badges129 bronze badges

Collectives™ on Stack Overflow

Error implementing Custom Validation in Laravel

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related