Comparing date in string format with current date in Date format using HTML and Javascript

Question

<html>
<head>
<script lang="Javascript">
function validateExpDate(){
    var expdate ="24-10-2018";
    var fields = expdate.split('-');
    var date = parseInt(fields[0]);
    var month = parseInt(fields[1]);
	var year = parseInt(fields[2]);
	var today = new Date();
    var dd = parseInt(today.getDate());
    var mm = parseInt(today.getMonth()+1); //January is 0!
    var yyyy = parseInt(today.getFullYear());
	if(year >= yyyy){
		if(month >= mm){
			if(date > dd){
				alert('Valid Expiry Date');
			}
		}	
	}else{
	alert('Invalid Expiry Date Entered!');
	}
}
</script>
</head>
<body onload="validateExpDate();">
</body>
</html>

I want to compare the date in variable expdate with current date and display appropriate message. Can anyone figure out the problem and make it work?

Debugging tip - you can put console.log(year, yyyy, month, mm, date, dd) before your if to see the values you'd be comparing. You can also use the debugger to look at them and step through the execution to see what, if anything, is wrong. — VLAZ
– VLAZ, Commented Oct 30, 2018 at 7:13
all values are coming. It's just comparison is not happening and it's frustrating. — Arvind Bakshi
– Arvind Bakshi, Commented Oct 30, 2018 at 7:30
The comparison is happening. Think about it, if month >= mm or date > dd fails, then where does the code go? — VLAZ
– VLAZ, Commented Oct 30, 2018 at 7:32

Jns · Accepted Answer · 2018-10-30 07:46:13Z

Your else instruction belongs to the outer if statement. In your case the if statement returns true (2018 >= 2018) so the program jumps to the code inside of the first if-clause. From then on your else statement is no longer reachable for the program.

You are looking for something like this:

<html>
<head>
<script lang="Javascript">
function validateExpDate(){
    var expdate ="24-10-2018";
    var fields = expdate.split('-');
    var date = parseInt(fields[0]);
    var month = parseInt(fields[1]);
    var year = parseInt(fields[2]);
    var today = new Date();
    var dd = parseInt(today.getDate());
    var mm = parseInt(today.getMonth()+1); //January is 0!
    var yyyy = parseInt(today.getFullYear());
    if(year >= yyyy && month >= mm && date > dd)
    {
        alert('Valid Expiry Date');
    }
    else{
    alert('Invalid Expiry Date Entered!');
    }
}
</script>
</head>
<body onload="validateExpDate()">
</body>
</html>

You have all conditions in one if clause. By using the AND operator this statement returns only true if all conditions are true. If one of them is false the program will go inside the else clause.

It is also possible to compare two dates directly in javascript. Just a little less code...

<html>
    <head>
    <script lang="Javascript">
    function validateExpDate(){
        var expdate = new Date('2018-10-24');
        var today = new Date();
        if(expdate > today) {
            alert('Valid Expiry Date');
        }
        else {
            alert('Invalid Expiry Date Entered!');
        }
    }
    </script>
    </head>
    <body onload="validateExpDate()">
    </body>
</html>

Narendra · Accepted Answer · 2018-10-30 07:47:02Z

0

You are not handling the else conditions for date and month. Either you can write code like below or you can use && in first IF loop if that suits you.

if (year >= yyyy) {
                if (month >= mm) {
                    if (date > dd) {
                        alert('Valid Expiry Date');
                    } else {
                        alert('Invalid Expiry Date Entered!');
                    }
                }
                else {
                    alert('Invalid Expiry Date Entered!');
                }
            } else {
                alert('Invalid Expiry Date Entered!');
            }

answered Oct 30, 2018 at 7:47

Narendra

4,5842 gold badges24 silver badges40 bronze badges

Comments

Arvind Bakshi · Accepted Answer · 2018-11-09 09:05:24Z

0

Thanks guys. I figured out the problem was just curly brasis. Thanks for the effort of replying. Really Appreciated.

answered Nov 9, 2018 at 9:05

Arvind Bakshi

651 gold badge1 silver badge11 bronze badges

Collectives™ on Stack Overflow

Comparing date in string format with current date in Date format using HTML and Javascript

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related