PHP - creating a new array through nested arrays while creating a post/image relationship

Question

PHP 7.2
Wordpress 4.9.8
Advanced Custom Fields 5.7.7

I'm interested in creating an array where each item would hold:

post id
post title
array of images belonging to post

I am using an ACF repeater for every post that holds many images, the repeater name is carousel.

There is no connection between the WP post object and the ACF fields.

The issue:

nested foreach pushes all the images into the first post.

Expected:

nested foreach will fill the $randomArray only with images that belong to that post ID.

$workshop_posts_args = array(
    'post_type' => 'workshops'
);

$randomArray = [
    'post_id' => '',
    'post_title' => '',
    'post_image_url' => []
];
$post_query = new WP_Query($workshop_posts_args);
if ($post_query->have_posts()) {
    while ($post_query->have_posts()) {
        $post_query->the_post();
        $carousel_array = get_field('carousel', get_the_ID());
        echo "<h2>".get_the_title()."</h2>";
        if ($carousel_array) {
            foreach ($carousel_array as $carousel_images) {
                foreach ($carousel_images as $image) {
                    $randomArray['post_id'] = get_the_ID();
                    $randomArray['post_title'] = get_the_title();
                    $randomArray['post_image_url'][] = $image['url'];
                    echo 'image_url:'.$image['url'].'<br>The array: <pre>'.print_r($randomArray, true).'</pre>';
                    ?>
                    <?php
                }
            }
        }
    }
}
?>
<h1>TOTAL ARRAY</h1>
<pre><?php print_r($randomArray) ?></pre>

i have got your problem and updated my code in answer.check now — Death-is-the-real-truth
– Death-is-the-real-truth, Commented Nov 2, 2018 at 11:58

Death-is-the-real-truth · Accepted Answer · 2018-11-02 12:05:58Z

1

You are over-writing array index again and again inside loop and that's you problem.

so do:-

$randomArray = []; //before post_query

And change if block like below:-

if ($post_query->have_posts()) {
    while ($post_query->have_posts()) {
        $post_query->the_post();
        $id = get_the_ID();
        $randomArray[$id]['post_id'] = $id;
        $randomArray[$id]['post_title'] = get_the_title();
        $carousel_array = get_field('carousel', $id);
        if ($carousel_array) {
            foreach ($carousel_array as $carousel_images) {
                foreach ($carousel_images as $image) {
                    $randomArray[$id]['post_image_url'][] = $image['url'];
                    ?>
                    <?php
                }
            }
        }
    }
}

Note:- rest code will be same

the above code will give you post-id based multi-dimensional array. if you want indexes to be 0,1,2,3..... format then do:-

$randomArray = array_values($randomArray);

edited Nov 2, 2018 at 12:05

answered Nov 2, 2018 at 11:54

Death-is-the-real-truth

72.3k10 gold badges59 silver badges106 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

clusterBuddy Over a year ago

perfect. Now I know better how to treat these arrays, thanks !

Death-is-the-real-truth Over a year ago

@clusterBuddy glad to help you :):)

Osama Ibrahim · Accepted Answer · 2018-11-02 11:53:47Z

Use proper indexing of $randomArray like below:

<?php
  $workshop_posts_args = array(
  'post_type' => 'workshops'
);

$randomArray = array();
$post_query = new WP_Query($workshop_posts_args);
$index = 0;
if ($post_query->have_posts()) {
    while ($post_query->have_posts()) {
        $post_query->the_post();
        $randomArray[$index]['post_id'] = get_the_ID();
        $randomArray[$index]['post_title'] = get_the_title();
        $carousel_array = get_field('carousel', get_the_ID());
       //echo "<h2>".get_the_title()."</h2>";
       if ($carousel_array) {
        foreach ($carousel_array as $carousel_images) {
            foreach ($carousel_images as $image) {

                $randomArray[$index]['post_image_url'][] = $image['url'];
                //echo 'image_url:'.$image['url'].'<br>The array: <pre>'.print_r($randomArray, true).'</pre>';
                ?>
                <?php
            }
        }
    }
    $index++;
}
}
?>
<h1>TOTAL ARRAY</h1>
<pre><?php print_r($randomArray) ?></pre>

Collectives™ on Stack Overflow

PHP - creating a new array through nested arrays while creating a post/image relationship

The issue:

Expected:

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

The issue:

Expected:

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related