Can't get HTTP PUT request to work in ASP.NET Core

Question

I'm trying to update an entry in the game table. However, my PUT request in ASP.NET never seems to trigger, and I can't figure out why.

This is controller in ASP.NET:

[Route("game/{update.GameID}")]
[HttpPut]
public IActionResult updateGame([FromBody]Game update)
{
    var result = context.Games.SingleOrDefault(g => g.GameID == update.GameID);
    if (result != null)
    {
        result = update;
        context.SaveChanges();
    }
    return Created("", result);
}

And this is the code I use in Angular:

url:string;
constructor(private _http: HttpClient) {
    this.url = "https://localhost:44359/api/v1/"
};

putGame(id:number, game:Game){
    return this._http.put(this.url + "game/" + id, game);
}

Edit 1: I do have a list of GET-requests, which all work just fine. It's only the PUT-request that fails.

Do your other ASP.Net controllers successfully invoke Angular? Q: Have you tried using RouteDebugger? — paulsm4
– paulsm4, Commented Nov 10, 2018 at 23:59

Rahul · Accepted Answer · 2018-11-11 05:09:02Z

9

If you are using PUT request you need to add a resource id either to update or create new - so just don't combine your id with your object

[HttpPut("game/{id}")]
public IActionResult UpdateGame(int id, [FromBody]Game update) {
    //...
}

If you are using Asp.net Core you can just re-write your URL on your HTTP verbs attribute like the code above - So pass your resource id in the URL and bind your object in the body - Your URL should read as https://localhost:44359/api/v1/game/2

Hope this helps you - Happy coding !!

answered Nov 11, 2018 at 5:09

Rahul

2,1382 gold badges14 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Nkosi · Accepted Answer · 2018-11-11 00:10:15Z

2

The route template parameter {update.GameID} is not standard to what is suggested by documentation

Assuming the game id is an integer review the following

//PUT .../game/5
[Route("game/{id:int}")]
[HttpPut]
public IActionResult updateGame(int id, [FromBody]Game update) {
    //...
}

Reference Routing to controller actions in ASP.NET Core

I would also suggest you review the logic of the action as I do not believe it is doing what you think it does with updating the entity returned from the context.

answered Nov 11, 2018 at 0:10

Nkosi

249k38 gold badges472 silver badges506 bronze badges

3 Comments

Gabriel Luci Over a year ago

Yup. result = update doesn't do what you think it does.

MyNameIsGuzse Over a year ago

I did this, but it still won't call when I try out the put-request. I have added a breakpoint on updateGame() and attempt a put-request via postman, but it never triggers.

Andre Artus Over a year ago

As @Nkosi suggests, it may not do what you expect it should. Also check out learn.microsoft.com/en-us/aspnet/core/tutorials/…, there is an PUT example.

Md. Abdul Alim · Accepted Answer · 2018-11-11 02:10:17Z

1

Can you modify your defining route just like

[Route("game")]
[HttpPut]
public IActionResult updateGame([FromBody]Game update)
{
   //your code
}

And call from angular like

putGame(game:Game){
    return this._http.put(this.url + "game", game);
}

you can receive gameid from game object so don't need from url

answered Nov 11, 2018 at 2:10

Md. Abdul Alim

6991 gold badge6 silver badges20 bronze badges

Collectives™ on Stack Overflow

Can't get HTTP PUT request to work in ASP.NET Core

3 Answers 3

Comments

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related