How can i change my const char pointer to unique pointer?

Question

So I am trying to change my game and I found a problem where I couldn't make the change:

I have the following code:

    std::string fileContents = "";
  const char* contentsPtr = fileContents.c_str();

I tried making it:

const std::unique_ptr<char> contentsPtr = fileContents.c_str();

It doesn't work since there is no constructor to make the conversion from char* to unique_ptr so how can I make this change?

The pointer returned by c_str() is not up for grabs, it's owned by fileContents. You can't just shove it in a unique_ptr and let it own it. Why do you even think you need a unique_ptr in your case? — StoryTeller - Unslander Monica
– StoryTeller - Unslander Monica, Commented Nov 11, 2018 at 11:01
In that case, why have contentsPtr at all? What does your code use it for? — melpomene
– melpomene, Commented Nov 11, 2018 at 11:10
@Ninhow Explain what you really need to do. Why are you not supposed to use naked pointers? It's error-prone? It's inefficient? It looks ugly? It's hard to understand? — user202729
– user202729, Commented Nov 11, 2018 at 11:14
@Ninhow - That's not a bad goal in general. But one should not be going about it by way of cargo cult programming. — StoryTeller - Unslander Monica
– StoryTeller - Unslander Monica, Commented Nov 11, 2018 at 11:15
The question to ask is who owns the data. In this case it's fileContents. Smart pointers own the data and you cannot have more than one owner. Multiple shared pointers can share ownership with each other, but not with something else. You may want to watch youtu.be/JfmTagWcqoE — Michael Surette
– Michael Surette, Commented Nov 11, 2018 at 11:27

Bo R · Accepted Answer · 2018-11-11 11:03:57Z

5

You do not want a unique_ptr around any resource you do not own. In this case the pointer returned from c_str(). It still belongs to fileContents objects. If/when you get past actually getting a unique_ptr around c_str(), then you later have memory corruption.

answered Nov 11, 2018 at 11:03

Bo R

2,3811 gold badge12 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How can i change my const char pointer to unique pointer?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related