call_user_func_array throws an error when the method exist

Question

This is how I am reaching the _call method:

$model->delivery_price = $currencyConverter->convertPriceByGivenCurrencies(
                        $model->delivery_price,
                        $currency->id,
                        $model->order_currency
                    );

The function throws an error but the method exists below it. My __call looks like:

public function __call($name, $params)
    {
        if(method_exists(CurrencyConverter::className(), $name)){
            if($params[0] == 0 || $params[0]){
                call_user_func_array($name, $params);
            }else{
                throw new \Exception('Price must be a valid number!');
            }
        }
        throw new NotFoundException('Function doesn\'t exist');
    }

It passes the if condition but after that the error occures:

call_user_func_array() expects parameter 1 to be a valid callback, function 'convertPriceByGivenCurrencies' not found or invalid function name

And this is the convertPriceByGivenCurrencies method which is landed in the below the _call:

protected function convertPriceByGivenCurrencies($product_price, $product_price_currency_id, $select_currency_id)
    {
      ............
    }

What am I doing wrong here ? Thank you!

When you are checking whether the method name exists, you are passing a class name to do so. But where in your call_user_func_array call are you referring to that same class …? You are passing the function name only there, so it looks for a standalone function of that name. — misorude
– misorude, Commented Nov 13, 2018 at 7:44

jeroen · Accepted Answer · 2018-11-13 07:49:28Z

1

$name by itself is not a known function; it seems to be a method in the CurrencyConverter class.

So to call it, assuming it is a static method, you would need something like:

CurrencyConverter::$name(...$params);

Note that you need the ... operator to unpack $params

edited Nov 13, 2018 at 7:49

answered Nov 13, 2018 at 7:44

jeroen

91.8k22 gold badges118 silver badges132 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Toma Tomov Over a year ago

But the unpacking is avaible in 5.6 only. At least this is what the PHPStorm says :)

jeroen Over a year ago

@TomaTomov That's right, if you are on an earlier version you should probably upgrade :-)

Toma Tomov Over a year ago

In fact I am on PHP Version 7.2.6-1. it is not usable on higher version ?

jeroen Over a year ago

@TomaTomov It is available from 5.6 on, so you can use it without any problems. Does PHPStorm know you are on 7.2?

Toma Tomov Over a year ago

Guess he doesn't know because it is working :) Thank you very much!

Nigel Ren · Accepted Answer · 2018-11-13 07:51:37Z

1

Calling it with

call_user_func_array($name, $params);

it is expecting a standalone function called $name.

As it's a method in a class you need to add this information to the callable, if you want to call it on the current instance then use

call_user_func_array(array($this,$name), $params);

If it isn't a method in the current instance, then replace $this with the appropriate instance. Or change the method to be static and replace $this with the class name.

edited Nov 13, 2018 at 7:51

answered Nov 13, 2018 at 7:44

Nigel Ren

57.3k11 gold badges49 silver badges59 bronze badges

2 Comments

Toma Tomov Over a year ago

__call and protected function convertPriceByGivenCurrencies are both in CurrencyConverter class. And the variable $currencyConverter is instance of the CurrencyConverter class. Sorry about the unclear explanation :)

Toma Tomov Over a year ago

Your answer also works and both gave me some new knowledges. I wish I could mark more than 1 best answers. Thank you very much!

Collectives™ on Stack Overflow

call_user_func_array throws an error when the method exist

2 Answers 2

5 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related