Assign value from `forEach` without using element array

Question

What's the best way to minimize this code and also remove the need for a element array to assign the variable with the value from inside the forEach:

    @Override
    public List<User> getModel() {
        List<User> usersModel = new LinkedList<User>();
        IntStream.of(getWidgetCount()).forEach(i -> {
            Widget widget = getWidget(i);
            AuthManagerRow row = (AuthManagerRow) widget;
            User widgetModel = row.getModel();
            final Boolean[] contains = {false};
            usersModel.forEach(user -> {
                if(user.getObjectId().equals(widgetModel.getObjectId())) {
                    contains[0] = true;
                }
            });
            if(!contains[0]) {
                usersModel.add(widgetModel);
            }
        });
        return usersModel;
    }

Just use normal for/each loops: for (User user : usersModel) — shmosel
– shmosel, Commented Nov 14, 2018 at 23:59
User widgetModel = (((AuthManagerRow) getWidget(i)).getModel(); - save a few lines — Scary Wombat
– Scary Wombat, Commented Nov 15, 2018 at 0:01
IntStream.of(int) returns a stream with a single element. Did you actually mean to use IntStream.range(0, getWidgetCount())? — Ilmari Karonen
– Ilmari Karonen, Commented Nov 15, 2018 at 0:18

Adam Siemion · Accepted Answer · 2018-11-15 00:13:43Z

2

Map<Integer, User> users = new HashMap<>();
IntStream.of(getWidgetCount())
  .mapToObject(i -> ((AuthManagerRow) getWidget(i)).getModel())
  .forEach(model -> users.putIfAbsent(model.getObjectId(), model));
return new ArrayList<>(users.values());

Assuming User.getObjectId() returns Integer.

edited Nov 15, 2018 at 0:13

answered Nov 15, 2018 at 0:05

Adam Siemion

16.1k9 gold badges61 silver badges97 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Adam Siemion Over a year ago

because only the first User for the given ObjectId should be returned

Collectives™ on Stack Overflow

Assign value from `forEach` without using element array

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related