Passing parameter in javascript function is giving error

Question

I am using extjs grid , and i put a render function on a coloumn of a grid

/** 
    * function for rendering the link
    **/
    function linkRenderer(data, cell, record, rowIndex, columnIndex, store) {
        console.log(record.id);
        if  (data != null)  {
            return '<a href="javascript:void(0)" onclick="resellerwindow('+record.id+')">' + data + '</a>';
        }
        return data;
    }

while on clicking the link i got an error that whatever the value of record.id is not not defined

Please suggest what solution i can do .

open firebug or similar and check the properties of record prior to calling linkRenderer. Chances are that you are not passing the thing you think you are. — Fraser
– Fraser, Commented Mar 17, 2011 at 10:42
@ChrisR m getting the value in string like city name i am using here — XMen
– XMen, Commented Mar 17, 2011 at 10:45

Abdel Raoof Olakara · Accepted Answer · 2011-03-17 11:21:14Z

1

Do you have a idProperty set for your store? set the idProperty to one of the values used to identify unique records. This will ensure that record.id is set to a value. For accessing all other values of the record, you will have to access them through record.data.proerty

Update: You need to use escape characters so that the string values are properly passed to the resellerwindow method:

<a href="javascript:void(0)" onclick="resellerwindow(\''+record.id+'\')"> + data + '</a>'

edited Mar 17, 2011 at 11:21

answered Mar 17, 2011 at 10:46

Abdel Raoof Olakara

19.4k11 gold badges92 silver badges134 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

XMen Over a year ago

Yeah ` idProperty: 'cityname',`

Abdel Raoof Olakara Over a year ago

did you check your generated HTML is correct after rendering the grid? use firebug and check a particular cell's HTML

XMen Over a year ago

<a href="javascript:void(0)" onclick="resellerwindow(bangalore)">68</a> it is this

Abdel Raoof Olakara Over a year ago

there you go.. you are missing a quotes it should be: resellerwindow("bangalore").. since you are passing a string to the method

XMen Over a year ago

Abdel nice idea of checking in firebug

|

Osaaaaq · Accepted Answer · 2011-03-17 10:43:37Z

0

But that's pretty clear the value of record.id is not define. Dah!

answered Mar 17, 2011 at 10:43

Osaaaaq

1

Comments

ChrisR · Accepted Answer · 2011-03-17 11:19:59Z

0

If the output of your console log is a string you are calling your function wrong, you are missing some quotes if record.id is a string.

function linkRenderer(data, cell, record, rowIndex, columnIndex, store) {
    if  (data != null)  {
        return String.format('<a href="javascript:void(0)" onclick="resellerwindow(\'{0}\')">{1}</a>', record.id, data);
    }
    return data;
}

answered Mar 17, 2011 at 11:19

ChrisR

14.5k17 gold badges73 silver badges112 bronze badges

1 Comment

ChrisR Over a year ago

String.format is a method on the String object in ExtJS. check the docs: dev.sencha.com/deploy/dev/docs/?class=String

Collectives™ on Stack Overflow

Passing parameter in javascript function is giving error

3 Answers 3

8 Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

8 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related