Add multiple elements to an array php

Question

i try to add multiple elements to an array (in this case example1 and test1 to $allCats) but it still dont work :( can anyone explain me my mistake? or what i do wrong?

function getCats($Catlist, $name) {
   $regex = '('.implode('|', $Catlist).')';
   $success = preg_match_all($regex, $name, $matches);
   return $success ? $matches[0] : [];

}


function Cats($name, $wrongCatlist, $allCats, $Catlist) {

        $Cats = getCats($Catlist, $name);
        $Cats2 = array_unique ( $Cats );
        $Cats3 = '"'.implode('", "', $Cats2).'"'; 
        array_push($allCats, $Cats3);
}

        $name = "adidas example1 handschuhe test1 nike";
        $wrongCatlist = [
        ];
        global $allCats;
        $allCats = [
        ];
        $Catlist = [
        "example1",
        "test1"
        ];
        Cats($name, $wrongCatlist, $allCats, $Catlist);
        $allCats2 = ''.implode(', ', $allCats).'';
        echo $allCats2;

Nishant · Accepted Answer · 2018-12-02 02:24:45Z

1

In PHP array is passed by value. Since you want the array $allCats to be updated the variable should get passed by reference. For that your function definition will be:

function Cats($name, $wrongCatlist, &$allCats, $Catlist) {

    $Cats = getCats($Catlist, $name);
    $Cats2 = array_unique ( $Cats );
    $Cats3 = '"'.implode('", "', $Cats2).'"'; 
    array_push($allCats, $Cats3);
}

Since pass by reference can sometimes lead to confusion, you should use return statement in function. Then the function and its call will change as below:

function Cats($name, $wrongCatlist, $allCats, $Catlist) {

    $Cats = getCats($Catlist, $name);
    $Cats2 = array_unique ( $Cats );
    $Cats3 = '"'.implode('", "', $Cats2).'"'; 
    array_push($allCats, $Cats3);
    return $allCats;
}

$allCats = Cats($name, $wrongCatlist, $allCats, $Catlist);

answered Dec 2, 2018 at 2:24

Nishant

7,9121 gold badge24 silver badges37 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

x123 Over a year ago

but that dont add $Cats3 to $allCats when i write $echo $allCats;

Nishant Over a year ago

$allCats is initialised as empty array. getCats returns Array ( [0] => example1 [1] => test1 ) which is then concatenated and imploded and stored in $Cats3 as "example1", "test1". This string is then pushed to $allCats empty array.

Collectives™ on Stack Overflow

Add multiple elements to an array php

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related