Jquery add parameter to function in for loop

Question

I have this:

$.ajax({
url: "blah.php?something",
dataType: "json"
....
success: function(x){
    for(i in x.artists) {
    addbutton.text(x.artists[i].name).click(function(){
    load(x.artists[i].name)
});
}
});

It's for a music player, and this is a suggestions engine. It loads artist names through AJAX, in JSON format from the PHP file, as you can see.

The problem is with the click() function which is supposed to load songs related to that artist. When the function gets called (ie the button gets clicked), instead of passing the artist's name as a string to load(), it passes x.artists[i].name, which of course is invalid outside of the ajax success function.

How would I go about solving this?

Thanks, Fela

Ant · Accepted Answer · 2011-03-22 13:17:15Z

1

Replace

load(x.artists[i].name)

with

load($(this).text())

answered Mar 22, 2011 at 13:17

Ant

3,8671 gold badge17 silver badges14 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Chandu · Accepted Answer · 2011-03-22 13:18:09Z

1

Change your addButton click handler to:

addbutton.text(x.artists[i].name).click(function(){     
   load($(this).text()) 
 });

or change the for loop to as follows(in case the text of the button is changed by some other code before the button is clicked.):

for(i in x.artists) {     
  var artistName = x.artists[i].name;
  addbutton.text(artistName ).click(function(){     
   load(artistName) ;
  }); 
}

answered Mar 22, 2011 at 13:18

Chandu

83.2k19 gold badges137 silver badges136 bronze badges

Comments

Billy Moon · Accepted Answer · 2011-03-22 13:18:32Z

1

Seeing as how you are setting the text value first - you can just re-use that if you like:

addbutton.text(x.artists[i].name).click(function(){ load($(this).text()) })

answered Mar 22, 2011 at 13:18

Billy Moon

58.9k27 gold badges148 silver badges245 bronze badges

Collectives™ on Stack Overflow

Jquery add parameter to function in for loop

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related