jQuery Each() function not working

Question

I'm trying to add a class to each div.banner inside of my #destaques, but isn't working. What's happening?

JS:

$(document).ready(function() {
  bannerRotator("#destaques");
});



function bannerRotator(element) {

  // Conta quantos banners existem:

  i = 0;

  $(element).find(".banner").each(function() {
    i++;
    $(this).addClass("test");
  });

  alert(i);

  //

}

HTML:

<div id="destaques">
<div class="banner"><img src="images/001.jpg"/></div>
<div class="banner"><img src="images/002.jpg"/></div>
<div class="banner"><img src="images/003.jpg"/></div>
</div>

var i = $('#destaques .banner').addClass('test').length,

Josiah Ruddell
– Josiah Ruddell

2011-03-22 18:57:05 +00:00
Commented Mar 22, 2011 at 18:57 — Josiah Ruddell
– Josiah Ruddell, Commented Mar 22, 2011 at 18:57
Working for me.

Brad Christie
– Brad Christie

2011-03-22 18:58:30 +00:00
Commented Mar 22, 2011 at 18:58 — Brad Christie
– Brad Christie, Commented Mar 22, 2011 at 18:58

Mark Coleman · Accepted Answer · 2011-03-22 18:57:22Z

6

addClass will work on a collection automatically.

$("#destaques").find(".banner").addClass("test");

Example on jsfiddle.

side note: this could be also be simplified to

$("#destaques .banner").addClass("test");

answered Mar 22, 2011 at 18:57

Mark Coleman

40.9k9 gold badges84 silver badges101 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

FarligOpptreden Over a year ago

You can simplify that even further with a selector: $("#destaques .banner").addClass("test");

Mark Coleman Over a year ago

@FarligOpptreden, thanks for the reminder, updated the answer with your suggestion.

Michael Koper · Accepted Answer · 2011-03-22 18:59:19Z

0

Try this

jQuery.each($("div.banner"), function() {
  i++;
  $(this).addClass("test");
});

But if you just want to add the class you can also do it in the following one liner

alert($('div.banner').addClass("test").length);

answered Mar 22, 2011 at 18:59

Michael Koper

9,8217 gold badges48 silver badges61 bronze badges

Collectives™ on Stack Overflow

jQuery Each() function not working

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related