Angular 2 change array value on subscribe

Question

I want to change some values in an array after I subscribe to it.

this.data = this.search.getProductsById(this.id).subscribe
    ((data: any) => {
        this.list = data;
        //Here for each price I want to change price value 
        for (let entry of this.list.deals.new) {
            if (entry.country == 'UK') {
                let p = entry.price * 1.10837; //here I change price
                console.log(p); //displays new price
            }
        }
        this.loading = true;
    });

But in HTML it displays old price, not p. How to change it so I would get in html new one ?

Your example doesn't show you aren't updating the price. By using let you are creating a new variable and aren't assigning it to anything. Changing the value would be done by doing something like entry.price = entry.price * 1.10837; — peinearydevelopment
– peinearydevelopment, Commented Jan 3, 2019 at 13:47
As @AndrėjusLazauskas said, you are just changing it locally. — Amit Chigadani
– Amit Chigadani, Commented Jan 3, 2019 at 13:49

B.Benjo · Accepted Answer · 2019-01-03 13:48:47Z

4

I think it's because you didn't set the new value p in your array, i think it's like this:

this.data =  this.search.getProductsById(this.id).subscribe
((data: any) => {
    this.list = data;
//Here for each price I want to change price value 
   for(let entry of this.list.deals.new){
     if(entry.country == 'UK'){
      entry.price *= 1.10837;
      console.log(entry.price); //displays new price
     }
   }
    this.loading = true;
}

answered Jan 3, 2019 at 13:48

B.Benjo

5734 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Devla Over a year ago

Yes... Sometimes just dumb mistakes.. Sorry.

Roman Lytvynov · Accepted Answer · 2019-01-03 16:04:04Z

2

As I understand, your method getProductsById() return an array of deals which have country field. If I understand correctly, you should use map operator something like this

this.data = this.search.getProductsById(this.id)
.pipe(map((data: any) => {
  if (data.deals.country === 'UK') {
    return data.deals.price = data.deals.price * 1.10837;
  }
}))
.subscribe(data => console.log(data.deals.price));

For better understanding give us the structure of the returned object

edited Jan 3, 2019 at 16:04

answered Jan 3, 2019 at 14:15

Roman Lytvynov

5132 silver badges13 bronze badges

Comments

Tushar Walzade · Accepted Answer · 2019-01-03 14:10:39Z

1

Your p is local to your if condition in a class only. You simply need to assign the value to the variable property itself.

So, just replace the line let p = entry.price * 1.10837; with entry.price = entry.price * 1.10837; That's it!

answered Jan 3, 2019 at 14:10

Tushar Walzade

3,8274 gold badges38 silver badges60 bronze badges

Collectives™ on Stack Overflow

Angular 2 change array value on subscribe

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related