Spring Data Elasticsearch working fine for saving data but returns empty array with findAll

Question

I have made an application using Springboot and running Elasticsearch in the background, everything works fine and when I am saving data by passing some json data it returns the right result(the number of inserted data) but when I am trying to fetch the datas it is returning empty array symbols.

Not getting what's happening can anybody please help.

And I have attached the screenshots of my postman requests.

For Saving data

For Fetching data

My api class:-

@SpringBootApplication
@RestController
public class SpringBootElasticserachExampleApplication {

@Autowired
private HeroRepository repository;

@PostMapping("/saveHero")
public int saveCustomer(@RequestBody List<Hero> heros) {        

    repository.saveAll(heros);
    return heros.size();
}

@GetMapping("/findAll")
public Iterable<Hero> findAllHeros() {

    return repository.findAll();
}
}

Model class:

@Document(indexName="movie",type="hero",shards=2)
@Data
@AllArgsConstructor
@NoArgsConstructor
public class Hero {

@Id
private String id;
private String firstname;
private String lastname;
private int age;

}

Repository:

public interface HeroRepository extends ElasticsearchRepository<Hero, String>{

List<Hero> findByFirstname(String firstName);

}

Please include the code and screenshots in the question. stackoverflow.com/help/mcve — Nikhil
– Nikhil, Commented Jan 4, 2019 at 13:06
heros.size() would return the size whether the data is stored or not — Emmanuel Osimosu
– Emmanuel Osimosu, Commented Jan 4, 2019 at 14:08
Iterable<Hero> savedHeroes = repository.saveAll(heros); should get you what has been saved and the size. — Emmanuel Osimosu
– Emmanuel Osimosu, Commented Jan 4, 2019 at 14:19
@eosimosu Yes I know that. But I have started with a new cluster and index too when I wants to save 4 json objects, it returns me the count as 4. And when I call the findAll() it shows 4 empty array symbols.Then after if I try to save one json object and by calling findAll() it shows 5 empty array symbols. — Xwin
– Xwin, Commented Jan 5, 2019 at 14:01

Imranmadbar · Accepted Answer · 2021-10-12 13:09:30Z

2

It is a Bean creation issue, Lombok Did not properly work here.

I solved this by adding Manually Getter Setter.

answered Oct 12, 2021 at 13:09

Imranmadbar

5,6004 gold badges22 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

riorio · Accepted Answer · 2019-01-04 15:21:35Z

0

Are you sure your data is saved in the DB? Did you query the DB directly and can see the data there? Like others wrote before me, your current code simply returns the number of input items. not necessarily the real amount of items that were saved.
Seems like your findAllHeros is calling repository.findAll(); (that you inherit from parent repositoy). But in your repository you have created a different method : List<Hero> findByFirstname(String firstName); Is it just a typo?

Also, I would expect the Controller with findAllHeros to return a list and not Iterable

edited Jan 4, 2019 at 15:21

answered Jan 4, 2019 at 15:15

riorio

6,90610 gold badges61 silver badges116 bronze badges

2 Comments

Nikhil Over a year ago

I think findByFirstname(String firstname) is fine. See: docs.spring.io/spring-data/elasticsearch/docs/current/reference/…

Xwin Over a year ago

@rioio findByFirstname(String firstName ) this is a different method which I have created because the doesn't have this one inbuit. But the Elasticsearch Repo has the findAll() method in it. and I am not saving the data into DB just working with Elastic only.

sasmita panigrahi · Accepted Answer · 2019-02-20 12:23:02Z

0

I think your code is adding the JSON object to ElasticSearch, but data is not saved. So you need to save the data with return type as List, don't return size only.

@PostMapping("/saveCustomer")
public List<Customer> saveCustomer(@RequestBody List<Customer> customers) {
  List<Customer> savedCustomer= repository.save(customers);
  //return customers.size();
  return savedCustomer;
}

In repository write

List<Customer> save(List<Customer> customers);
Iterable<Customer> findAll();

edited Feb 20, 2019 at 12:23

answered Feb 20, 2019 at 12:06

sasmita panigrahi

12 bronze badges

Collectives™ on Stack Overflow

Spring Data Elasticsearch working fine for saving data but returns empty array with findAll

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related