Nested struct is not updated

Question

I have a nested struct. I want to update it inside a method. For some reason, the update doesn't take place.

    package main

    import "fmt"

    type B struct {
        c int
    }

    type A struct {
        b B
    }

    func (a A) updateB(n int) {
        a.b.c = n
    }

    func main() {
        a := A{b: B{c: 5}}

        fmt.Println(a)
        a.updateB(42)
        fmt.Println(a)
    }

The output I get is

{{5}}
{{5}}

In most languages, I'd expect it to be updated. Is this some special Go behavior? How does one go about updating nested structs in Go?

Iain Duncan · Accepted Answer · 2019-01-20 06:57:13Z

6

It is because you are using a value receiver so the updateB method receives a copy of the value of A rather than a pointer to the memory that contains the a variable. Using a pointer receiver fixes the problem:

package main

import "fmt"

type B struct {
    c int
}

type A struct {
    b B
}

func (a *A) updateB(n int) {
    a.b.c = n
}

func main() {
    a := A{b: B{c: 5}}

    fmt.Println(a)
    a.updateB(42)
    fmt.Println(a)
}

https://play.golang.org/p/XBrxd246qT3

Comments

roethke · Accepted Answer · 2019-01-20 07:07:57Z

3

It's not because the struct is nested, rather it's because you need a pointer receiver to modify the value to which the receiver points, in this case your a variable.

Without the pointer your UpdateB method would only be updating a copy of the original A struct value.

See the following:

package main

import "fmt"

type B struct {
    c int
}

type A struct {
    b B
}

func (a *A) UpdateB(n int) {
    a.b.c = n
}

func main() {
    a := A{b: B{c: 5}}

    fmt.Println(a)
    a.UpdateB(50)
    fmt.Println(a)
}

edited Jan 20, 2019 at 7:07

answered Jan 20, 2019 at 6:57

roethke

1,1622 gold badges8 silver badges19 bronze badges

Comments

Ibu · Accepted Answer · 2019-01-21 00:22:32Z

3

The problem is with your update function. You are supposed to add it to the pointer to A.

func (a *A) updateB(n int) {
    a.b.c = n
}

edited Jan 21, 2019 at 0:22

answered Jan 20, 2019 at 6:56

Ibu

44k14 gold badges82 silver badges109 bronze badges

Comments

pr0p · Accepted Answer · 2019-01-20 07:01:00Z

1

For any interface for its objects to be updated by a function you need to pass the object by reference.

package main

import "fmt"

type B struct {
    c int
}

type A struct {
    b B
}

func (a *A) updateB(n int) {
    a.b.c = n
}

func main() {
    a := A{b: B{c: 5}}

    fmt.Println(a)
    a.updateB(42)
    fmt.Println(a)
}

https://play.golang.org/p/_o5sRApo6WP

answered Jan 20, 2019 at 7:01

pr0p

2,34816 silver badges34 bronze badges

Collectives™ on Stack Overflow

Nested struct is not updated

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related