Java read CSV file ,contents not write in new CSV file

Question

package com;
import java.io.FileReader;
import java.io.FileWriter;
import java.io.IOException;
import java.util.Arrays;
import com.opencsv.CSVWriter;
import com.opencsv.CSVReader;

public class Sample2 {
    public static void main(String args[]) throws IOException
    {
        CSVReader csvReader = null;  
        String[] employeeDetails ;        
        CSVWriter  csvWriter = new CSVWriter(new FileWriter("D:\\sample\\myfile.csv",true));
        csvReader = new CSVReader(new FileReader("D:\\sample\\source.csv"));          
        try
        {        

            employeeDetails = csvReader.readNext();               
            while ((employeeDetails = csvReader.readNext()) != null ) {               

                    System.out.println(Arrays.toString(employeeDetails));                   
                    csvWriter.writeNext(employeeDetails);
                }               

        }catch(Exception ee)
            {
                ee.printStackTrace();
            }
        }
}

I have my above java code It read data from source.csv file and also display in the console . It created myfile.csv ,but same contents it didn't write in the csv file Anyone have any idea on this

Did you try to close your FileWriter and CsvWriter? Try using try-with resources — Stephan Hogenboom
– Stephan Hogenboom, Commented Jan 23, 2019 at 13:56

Mohamed Anees A · Accepted Answer · 2019-01-23 14:52:33Z

1

CSVWriter implements Flushable.Working Solution is already present in @Stephan Hogenboom's answer. I will answer why didn't it write in your case,

From the javadocs of Flushable interface,

A Flushable is a destination of data that can be flushed. The flush method is invoked to write any buffered output to the underlying stream.

For performance reasons, all data is to be written into a Buffer instead of File temporarily. Once you call the flush() method, it flushes the data already present in the buffer into your file(this is where disk I/O happens, not when you call writeNext() ).

As mentioned on doc of flush() in java.io.Writer.

Flushes the stream. If the stream has saved any characters from the various write() methods in a buffer, write them immediately to their intended destination.

answered Jan 23, 2019 at 14:52

Mohamed Anees A

4,6612 gold badges25 silver badges37 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Stephan Hogenboom Over a year ago

Good explanation!

Mohamed Anees A Over a year ago

Thanks @StephanHogenboom :)

Mohamed Anees A Over a year ago

I must say javadocs has answers for anything just if we know to read it right! :P

Stephan Hogenboom · Accepted Answer · 2019-01-23 14:58:05Z

0

The issue is that you don't close your output resources, try this code:

public static void main(String args[]) throws IOException {
String[] employeeDetails;

try (CSVWriter csvWriter = new CSVWriter(new FileWriter("D:\\sample\\myfile.csv", true));
    CSVReader csvReader = new CSVReader(new FileReader("D:\\sample\\source.csv"));
    ) {

  while ((employeeDetails = csvReader.readNext()) != null) {

    System.out.println(Arrays.toString(employeeDetails));
    csvWriter.writeNext(employeeDetails);
  }
}
catch (Exception ee) {
  ee.printStackTrace(); //perhaps you should also log the error?
}
}

Also take a look at this question Is closing the resources always important?

edited Jan 23, 2019 at 14:58

answered Jan 23, 2019 at 14:06

Stephan Hogenboom

1,5723 gold badges19 silver badges33 bronze badges

Collectives™ on Stack Overflow

Java read CSV file ,contents not write in new CSV file

2 Answers 2

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related