android, how to cancel current request in retrofit2/rxjava-android

Question

I am new in retrofit/rxjava-android

Someone told me that, it is best practice if I will cancel the request if the call is not yet finished and the user leaves the activity page.

I am having problem where/how to cancel it.

Here's my code, it is working properly.

Observable<List<MyObject>> call;
public void getStaticMessages() {
    call = restInterface.loginURL();
    call.subscribeOn(Schedulers.io())
            .observeOn(AndroidSchedulers.mainThread()).subscribe(new Observer<List<MyObject>>() {
        @Override
        public void onCompleted() {

        }

        @Override
        public void onError(Throwable e) {
            Log.d("LOGGER", "error");
        }

        @Override
        public void onNext(List<MyObject> myObjects) {
            Log.d("LOGGER", "succcess");
        }
    });

}

Valerii · Accepted Answer · 2019-02-08 20:49:09Z

1

One of the best practice is to create subscription/disposable when onStart() method of activity/fragment is called and unsubscribe /dispose when onStop called.

You can create one disposable Disposable disposable = call.subscribeOn and dispose it via disposable.dispose() or use CompositeDisposable.

I used the same approach with CompositeDisposable in one of my previous pet projects - link

answered Feb 8, 2019 at 20:49

Valerii

4051 gold badge3 silver badges8 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

android, how to cancel current request in retrofit2/rxjava-android

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related