PHP if greater than [duplicate]

Question

I am trying to echo a specific message if the numerical value of $mqmtxt is greater than 20.

The value is in a txt file, the value is 7 so should be showing NO WARN but is showing WARN. Not sure what I am missing here.

<?php
   $mqmtxt = file_get_contents("./MQM/mqmcount.txt");
   $mqmtxt = preg_replace('/[\x00-\x1F\x7F-\xFF]/', '', $mqmtxt);
   if ($mqmtxt >= "20"){
      $mqmwarning = "WARN";
   }else{
      $mqmwarning = "NO WARN";
   }
?>

<!DOCTYPE html>
<html>
    <body>
        <div id="dispmqmcount"><?php echo $mqmtxt; ?></div>
        <div id="warning"><?php echo $mqmwarning; ?></div>
    </body>
</html>

change this line if ($mqmtxt >= "20"){ to if ($mqmtxt >= intval("20")){ — Satya
– Satya, Commented Feb 25, 2019 at 11:26
You are making a string comparison, not a int comparison. Try casting — user10123001
– user10123001, Commented Feb 25, 2019 at 11:28
Do the typecasting on $mqmtxt. The code would be like this if ( (int)$mqmtxt >= 20) {....) — Nishad Up
– Nishad Up, Commented Feb 25, 2019 at 11:28
The answer below (and comment) both solved the issue, the dump was 7 as stated in the question. Thank you all — Sauced Apples
– Sauced Apples, Commented Feb 25, 2019 at 11:30

Nick · Accepted Answer · 2019-02-25 11:25:43Z

6

You are comparing the string "7" with the string "20" and since '7' > '2' your if test passes and WARN is displayed. You need to convert both values to integer to correctly compare e.g.

if ((int)$mqmtxt >= 20) {

answered Feb 25, 2019 at 11:25

Nick

147k23 gold badges67 silver badges106 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Mike Doe Over a year ago

A variable is always implicitly converted to an integer during compare so your cast to int is unnecessary.

deceze Over a year ago

@emix Always?! Since you can use greater-than operators to compare strings too, that can't be true.

Mike Doe Over a year ago

Not sure what you mean @deceze. You can compare strings, but before PHP does that, both sides are converted to int.

deceze Over a year ago

@emix You're saying both strings in 'foo' > 'bar' are converted to ints before comparison?!

Mike Doe Over a year ago

You took my words too literally ;) Of course there's this type juggling magic involved.

Collectives™ on Stack Overflow

PHP if greater than [duplicate]

1 Answer 1

5 Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Linked

Related