Creating custom generics for get, update, delete and post with Django Rest Framework in Django

Question

I am thinking of refactoring my code because I think I'm repeating too much ending up with lines of code. Take of this instance below I have implemented a class based view to GET,PUT,and DELETE for the Unit Model. Later I will create another view for Department to do CRUD and will follow the same pattern,is there a way I can make custom generic model views that can be dynamically used in any other view.

class UnitDetailView(generics.RetrieveAPIView):
    """ Class based view for Unit Details. """

    serializer_class = UnitSerializer
    queryset = Unit.objects.all()

    def get_object(self, pk, org_id=None):
        try:
            return Unit.objects.get(pk=pk, org_id=org_id)
        except Unit.DoesNotExist:
            raise Http404

    def get(self, request, pk, format=None):
        """Get a unit instance."""
        unit_obj = self.get_object(pk, org_id=get_auth(request))
        serializer = UnitSerializer(unit_obj)
        return Response(serializer.data)

    def put(self, request, pk, format=None):
        """Update a unit instance."""
        unit_obj = self.get_object(pk, org_id=get_auth(request))
        serializer = UnitSerializer(unit_obj, data=request.data)
        if serializer.is_valid():
            serializer.save()
            return Response(serializer.data)
        return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)

    def delete(self, request, pk, format=None):
        """Remove a unit instance."""
        unit_obj = self.get_object(pk, org_id=get_auth(request))
        unit_obj.delete()
        return Response(status=status.HTTP_204_NO_CONTENT)

Headmaster · Accepted Answer · 2019-02-25 13:31:20Z

1

You can use viewsets.ModelViewSet. And you won't need to write every method (get, put, delete, update)

answered Feb 25, 2019 at 13:31

Headmaster

2,3526 gold badges35 silver badges62 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Philip Mutua Over a year ago

I had to override the methods to add org_id the function get_auth() returns the organization id the authenticated user is logged in. Therefore using viewsets would also require me to customize the methods like above so that I add org_id = get_auth(request)

Headmaster Over a year ago

@pmutua - where does get_auth() come from?

Philip Mutua Over a year ago

That is a custom function I implemented.

Headmaster Over a year ago

@pmutua - then provide its code. It's hard to say, if default behavior can help, when there is no full code

Philip Mutua Over a year ago

I understand, the approach I have implemented is to customize djangorestframework's mixins to fit my needs and it worked.

Collectives™ on Stack Overflow

Creating custom generics for get, update, delete and post with Django Rest Framework in Django

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related