Saving with mongoose to mongodb in a loop

Question

I want to save an object multiple times, with a change to the date field - adding one month per iteration.

A for loop doesn't work due to node async nature.

const saveMany = (req, res, obj, data) => {
    let saves = [];
    if (data.frequency === 'monthly') {
         let i = 0;
         for (let i = 0; i < data.reccuring_length; i++) {
            const newEntry = new obj(data);
            if (i != 0) newEntry.created_date.addMonths(1) //using datejs
            newEntry.save((err, entry) => {
                if (err) {
                    return res.status(400).send({
                        message: err
                    });
                }
                saves.push(entry);
            })

        }) //end of for loop
        return res.json(saves)

    } //end of if
}

I've seen stuff about promises / the async library but can't make a working implementation (I am new to this though so could be missing something obvious).

Any help is appreciated :)

EDIT: Saving To MongoDB In A Loop

Found this link which is relevant, but if anyone has other suggestions that would be great.

EDIT 2:

Just realised my code has camelcase and snake case, changing in my code to make all object data snake case.

use Promise.all so you can call then on all promises (after saving everything) — molamk
– molamk, Commented Feb 26, 2019 at 22:56
@molamk Will give it a try. Thanks will feedback if I get it working. — Dom Needham
– Dom Needham, Commented Feb 27, 2019 at 17:58

Veldars · Accepted Answer · 2019-02-27 10:53:20Z

1

I think you can do somethings like that:

const saveMany = async (req, res, obj, data) => {
let saves = [];
if (data.frequency === 'monthly') {
     let i = 0;
     for (let i = 0; i < data.reccuring_length; i++) {
        const newEntry = new obj(data);
        if (i != 0) newEntry.created_date.addMonths(1) //using datejs
        try{
          const entry= await newEntry.save();
          saves.push(entry);
        } catch(err) {
          return res.status(400).send({ message: err });
        }
    }) //end of for loop
    return res.json(saves)

} //end of if
}

answered Feb 27, 2019 at 10:53

Veldars

1211 silver badge8 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Dom Needham Over a year ago

Only problem is that the code doesn't throw an error, it simply just doesn't save anything.

Veldars Over a year ago

Hum, ok... Can you copy your "obj" schema and what is inside your "data" object ? Also a call example of the function could help (to see if you pass the model by example). I use this kind of code and it save perfectly my docs. Maybe reccuring_length is 0 or frequency is not monthly.

Dom Needham Over a year ago

You are correct, works a dream. I was passing recurring_length with a typo so nothing being saved. Thank you so much

Collectives™ on Stack Overflow

Saving with mongoose to mongodb in a loop

1 Answer 1

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related