Display all rows returned by SQL query in a div

Question

I'm trying to output the result of my SQL query to a div using the InnerHTML. but I can't get more than one record to show up. How do I make it so that all of my records are displayed in the DIV? On my page I have the DIV contained within a UpdatePaneland I only 1 row is displayed even when the query returns more than one row.

string sql = "Select * From Events";
SqlCommand command = new SqlCommand(sql, conn);
command.CommandType = CommandType.Text;
conn.Open();
reader = command.ExecuteReader();
while (reader.Read())
{
    divout1.InnerHtml += "Name: " + reader["Name"].ToString() + "<br />" +
        "Date: " + reader["Date"].ToString() + "<br />" +
        "Location: " + reader["Location"].ToString() + "<br />";
    divout.Visible = true;
}

This isn't the problem, but you need to escape the strings from the database before you put them in the div. — arx
– arx, Commented Mar 30, 2011 at 18:53

Flavio CF Oliveira · Accepted Answer · 2011-03-30 18:53:05Z

1

Well, at first look, unless your query returns only one row, it should get all data on your div.

try to put a break point on the last bracket of your while statement and see what happens on your div after first iteration.

for other way, try to put the div out of the updatepanel to see what appens?

answered Mar 30, 2011 at 18:53

Flavio CF Oliveira

5,29514 gold badges43 silver badges64 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mohamed Nuur · Accepted Answer · 2011-03-30 18:51:48Z

1

Why not use a StringBuilder to build your sql and then output the contents of the StringBuilder:

StringBuilder sb = new StringBuilder(1024);
string sql = "Select * From Events";
SqlCommand command = new SqlCommand(sql, conn);
command.CommandType = CommandType.Text;
conn.Open();
reader = command.ExecuteReader();

while (reader.Read())
{
    sb.AppendLine("Name: " + reader["Name"].ToString() + "<br />" +
        "Date: " + reader["Date"].ToString() + "<br />" +
        "Location: " + reader["Location"].ToString() + "<br />");
}

if(sb.Length > 0) {
    divout.InnerHtml = sb.ToString();
    divout.Visible = true;
}

answered Mar 30, 2011 at 18:51

Mohamed Nuur

5,6757 gold badges42 silver badges56 bronze badges

Comments

Gboyega Sulaiman · Accepted Answer · 2011-03-30 18:52:36Z

1

Why not try something like this, may be concatenating inside the InnerHtml is screwing up or something. also be sure you really have more than one row.

    var sb = new StringBuilder();  
    var formatString = "Name: {0} <br />Date: {1}<br />Location: {2}<br />"; 
    while (reader.Read())
    {
        sb.AppendFormat(formatString, reader["Name"].ToString(), reader["Date"].ToString(), reader["Location"].ToString());
    }
    divout1.InnerHtml = sb.Tostring();
    divout1.Visible = true;

answered Mar 30, 2011 at 18:52

Gboyega Sulaiman

6415 silver badges15 bronze badges

Comments

Jonny · Accepted Answer · 2011-03-30 18:57:08Z

0

Try:

            string sql = "Select * From Events";
            SqlCommand command = new SqlCommand(sql, conn);
            command.CommandType = CommandType.Text;
            conn.Open();
            reader = command.ExecuteReader();
            string s = string.Empty;
            while (reader.Read())
            {
                s += "Name: " + reader["Name"].ToString() + "<br />" +
                    "Date: " + reader["Date"].ToString() + "<br />" +
                    "Location: " + reader["Location"].ToString() + "<br />";

            }
            divout1.innerHtml = s;
            divout1.Visible = true;

answered Mar 30, 2011 at 18:57

Jonny

2,93710 gold badges43 silver badges67 bronze badges

1 Comment

Jonny Over a year ago

Although using a StringBuilder is better

Conrad Frix · Accepted Answer · 2011-03-30 19:18:31Z

0

You should probably encode the strings coming from the Database since you're directly outputting it as raw HTML.

divout1.InnerHtml += "Name: " + Server.HtmlEncode(reader["Name"].ToString()) + "<br />" 
                   + "Date: " + Server.HtmlEncode(reader["Date"].ToString()) + "<br />"  
                   + "Location: " + Server.HtmlEncode(reader["Location"].ToString()) + "<br />";

see HttpServerUtility.HtmlEncode

answered Mar 30, 2011 at 19:18

Conrad Frix

52.8k13 gold badges100 silver badges158 bronze badges

Collectives™ on Stack Overflow

Display all rows returned by SQL query in a div

5 Answers 5

Comments

Comments

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related