While Loop looping only once when using getline from file

Question

I have this small bit of code:

fileopen.open(file_name);
while (getline(fileopen, line, ',')){
    string temp;
    vector<string> mug;
    temp = line;
    stringstream ss(temp);
    while (getline(ss, temp, ' ')){
        mug.push_back(temp);
    }
    stringstream conv;
    double vol, cos;
    conv << mug.at(1);
    conv >> vol;
    stringstream().swap(conv);
    conv << mug.at(3);
    conv >> cos;
    mugs.push_back(make_tuple(mug.at(0), vol, mug.at(2), cos));
    stringstream().swap(conv);
    stringstream().swap(ss);
    temp.clear();
}
sort(mugs.begin(), mugs.end(), sort_by);
for (int i = 0; i < mugs.size(); i++){
    cout << "Country: " << get<0>(mugs[i]) << " ";
    cout << ", Volume: " << get<1>(mugs[i]) << " ";
    cout << ", Material: " << get<2>(mugs[i]) << " ";
    cout << ", Price: " << get<3>(mugs[i]) << "\n";
}

I have multiple clears and stringstream().swap()'s because it is a well known issue. <sstream> seems to interrupt iterations for while loops. However, even this doesn't seem to be working. The input given from the file is as follows:

RUS 0.1 Wood 20
USA 0.4 Glass 0.5

The current code prints the first line as needed, but fails to iterate and print the second line. Any suggestions?

I have tried using continue and goto for solving this problem. None of those solutions have worked out.

On a side note: consider using std::strtod() or std::stod() to parse your string values into doubles, instead of using stringstream. And you don't need to swap() a stringstream to clear its data, you can use its str() method instead to assign a blank string. And you certainly don't need to swap()/clear() a container variable that will be going out of scope afterwards. — Remy Lebeau
– Remy Lebeau, Commented Mar 6, 2019 at 0:57
@RemyLebeau duly noted! I was thinking of using 'std::stod()' before however there were some troubles with it so i decided to whip up a temporary solution using stringstream — xarekSD
– xarekSD, Commented Mar 6, 2019 at 11:20

R Sahu · Accepted Answer · 2019-03-05 23:18:27Z

2

The input file, as posted, does not have , in any of the lines. Hence, use of

while (getline(fileopen, line, ',')){

does not make sense. Use

while (getline(fileopen, line)){

answered Mar 5, 2019 at 23:18

R Sahu

207k15 gold badges168 silver badges291 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

While Loop looping only once when using getline from file

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related