Detection script for windows hotfixes

Question

So we have recently had issues with the KB971033 update within our network and i have managed to get a working script for removing it and reactivating windows, however when trying to get a detection script working to assure it only runs on effected computers i cant get it to correctly output true or false when testing against installed KBs.

So far this is what im running. No matter what i do it will output false. Anything obvious i am missing?

if ((get-hotfix).hotfixid -eq "KB971033") {$true} else {$false}

Theo · Accepted Answer · 2019-03-08 15:10:42Z

2

(get-hotfix).hotfixid returns an array, so you should not compare that with -eq.

This ought to do it:

((Get-HotFix  | Select-Object -ExpandProperty HotFixID) -contains 'KB971033')

or for short:

(((Get-HotFix).HotFixID) -contains 'KB971033')

answered Mar 8, 2019 at 15:10

Theo

61.9k8 gold badges28 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

benrpr Over a year ago

Yeah for some reason this works perfectly, any reason that my code above would work fine on the server environment but not on our endpoint machines but the code above works fine?

Theo Over a year ago

@benrpr According to the docs, -eq returns a value of TRUE or the matches if one or more of the values is identical to the pattern. ((get-hotfix).hotfixid -eq "KB971033") should therefore return a one element array containing the string "KB971033". However, this is the case for PowerShell version 3.0 and up as far as I can tell. Anyway, I never use -eq when checking a value in an array. -contains, -in, -notcontains and -notin are designed for that.

user6811411 · Accepted Answer · 2019-03-08 15:18:33Z

1

It's IMO quite inefficient to sieve through all Hotfixes when testing a distinct one.

if (Get-Hotfix -ID KB971033 -EA 0) {$true} else {$false}

-EA 0 is an abbreviation for -ErrorAction SilentlyContinue

answered Mar 8, 2019 at 15:18

user6811411

Comments

Pink · Accepted Answer · 2019-03-08 14:52:49Z

0

Maybe Try

 if ($(get-hotfix).hotfixid -eq "KB971033") {$true} else {$false}

The "$" is going to make "Get-Hotfix" result into an object with member ".hotfixID".

answered Mar 8, 2019 at 14:52

Pink

481 silver badge11 bronze badges

1 Comment

benrpr Over a year ago

Still outputting false on a known installed update, im starting to think the problem might lie elsewhere and the code is in fact fine.

jeremias kühnis · Accepted Answer · 2019-03-08 14:57:17Z

0

In my Windows Server 2016 Environment your Code works fine...maybe the Hotfix is not installed or not listed with 'get-hotfix'

Otherwise you can try this:

$HotfixID= "KB971033"
IF((get-hotfix).hotfixid | ?{ $_ -eq $HotfixID}){$true} else {$false}

It works also on Remote Computer:

(get-hotfix).hotfixid -ComputerName "***SomeDNSName / FQDN***"

answered Mar 8, 2019 at 14:57

jeremias kühnis

234 bronze badges

1 Comment

benrpr Over a year ago

The hotfix is both installed and shows up when get-hotfix is run standalone.The updated version of the script still outputs false

Collectives™ on Stack Overflow

Detection script for windows hotfixes

4 Answers 4

2 Comments

Comments

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related