await not waiting javascript

Question

I have the following code:

var arrayAxios = [];
            
const array = async() => {
  await sleep(3000);
  _.forEach(tasks, task => {
    let res = _.includes("selected", task.value);
    if (res) {
      this.axios
        .get(url, { params: { data1 } })
        .then(response => {
          arrayAxios.push(this.axios.post(url, { dataAAA }));
        });
    }
  });
};
              
var promises = async() => {
  const arrayAxios = await array();
  await Promise.all(arrayAxios)
    .then(response => {
      resetAll_dataAAA();   // <--- my dataAAA in arrayAxios are reset before post in Promise.all!
    })
    .catch(error => {
      console.log(error);
    });
};

promises();

The function "resetAll_data()" is executed before the data is post into the DDBB. I can't find the problem.

Any suggestions?

Thank you very much!

arrayAxios (the one inside promises) is undefined because array doesn't return anything — ibrahim mahrir
– ibrahim mahrir, Commented Mar 9, 2019 at 13:35

Bergi · Accepted Answer · 2019-03-09 13:51:19Z

1

You are looking for

async function array() {
  await sleep(3000);
  var arrayAxios = []; // declare the array locally
  _.forEach(tasks, task => {
    let res = _.includes("selected", task.value);
    if (res) {
      arrayAxios.push(this.axios
//    ^^^^^^^^^^^^^^^ push to the array immediately, not asynchronously
        .get(url, { params: { data1 } })
        .then(response => {
          return this.axios.post(url, { dataAAA }));
//        ^^^^^^ chain the promises
        })
      );
    }
  });
  return arrayAxios;
//^^^^^^ give the result to the caller
}

answered Mar 9, 2019 at 13:51

Bergi

671k162 gold badges1k silver badges1.5k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Joe Warner · Accepted Answer · 2019-03-09 14:24:20Z

I've simplified your example so you can hopefully get what's going on :)

You need to return an array of promises from an array to be able to resolve them with Promise.all

there's no point using await Promise.all().then use await or then

array was never returning the request promise so when awaited it would of resolved straight away

sleep i dont believe is a function in node also.

any questions let me know happy to help.

const axios = {
  get: async(task) => {
    return task.res;
  },
  post: async(task) => {
    return task;
  }
}

const tasks = [{url: 'getting', res: {got: 'got the thing', post: 'thing to post'}}, {url: 'getting 2', res: {got: 'got the thing 2', post: 'thing to post 2'}}]

const getRequest = async(url = '') => { 
  const res = await axios.get(url)
  console.log(res.got)
  return postRequest(res.post)
}

const postRequest = async (url = '') => {
  const res = await axios.post(url)
  console.log(res)
  return res;
}

const array = async() => {
  const createRequests = async task => {
    return getRequest(task)
  }

  return tasks.map(createRequests).filter(Boolean);
};

const promises = async() => {
  console.log('waiting')
  const res = await array()
  const all = await Promise.all(res)
  console.log('awaited')
  console.log('can call your reset')
};

promises();

Collectives™ on Stack Overflow

await not waiting javascript

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related