PHP parse REQUEST_URI into array

Question

I am parsing the REQUEST_URI into an array.

Right now i have the following code:

private function load_url_vars()
{
    if (preg_match('/^.+\?(.+)$/', $_SERVER["REQUEST_URI"], $matches))
    {
        $varpairs = preg_split("/&/", $matches[1]);
        foreach ($varpairs as $varpair)
        {
            if (preg_match('/^([A-Za-z_]+)=(.*)$/', $varpair, $varmatch))
            {
                $this->urlvars[$varmatch[1]] = urldecode($varmatch[2]);
            }
        }
    }
}

Are there any security concerns by doing it this way? Is this a good way of parsing it?

Edit: language

There are no security concerns, but you already get all that in _GET superglobal so what's the point of your code? — Michael J.V.
– Michael J.V., Commented Apr 1, 2011 at 13:02
when using mod_rewrite it's better to parse it in php, than in .htaccess — OMGKurtNilsen
– OMGKurtNilsen, Commented Apr 1, 2011 at 13:15
I've read all current comments and you're wrong in your idea. It doesn't matter if you use mod_rewrite or not, even if your url looks like /controller/method/id/?some_long_text=some_variable - you will have them available under $_GET array, as long as there's properly formed querystring that can be parsed into $_GET. Test it before you try to fix it. — Michael J.V.
– Michael J.V., Commented Apr 1, 2011 at 13:31
I did test that before I even made this post. This is the var_dump($_GET) for "/home/index/?test=willitwork": array(2) { ["controller"]=> string(4) "home" ["method"]=> string(5) "index" } — OMGKurtNilsen
– OMGKurtNilsen, Commented Apr 1, 2011 at 14:02
PHP parses the url that mod_rewrite made, not the one the sent from user. — OMGKurtNilsen
– OMGKurtNilsen, Commented Apr 1, 2011 at 14:04

Shakti Singh · Accepted Answer · 2011-04-01 13:02:13Z

22

You also can do with php in built functions. Which will be an efficient way.

$urlArr=parse_url($_SERVER['REQUEST_URI']);
parse_str($urlArr['query'], $output);

print_r($output);

answered Apr 1, 2011 at 13:02

Shakti Singh

86.7k21 gold badges142 silver badges156 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Henrik Erlandsson Over a year ago

+1 Probably more useful for most than the accepted answer. Path relative to the root in $urlArr[0] and a neat array with path, whole query, and separate query parameters in $output. Works well together with redirecting non-files and non-directories to index.php or similar using .htaccess.

Soul Reaver Over a year ago

simplest answer and far better, considering that accepted answer will throw warning, if there's no query part in the URI

mario · Accepted Answer · 2011-04-01 13:03:14Z

8

There is no security concern, but your solution is quite fiddly. It's already possible to accomplish that with parse_str (and parse_url for splitting up the path). Or in your case just:

list($path, $qs) = explode("?", $_SERVER["REQUEST_URI"], 2);
parse_str($qs, $this->urlvars);

answered Apr 1, 2011 at 13:03

mario

146k20 gold badges243 silver badges293 bronze badges

2 Comments

OMGKurtNilsen Over a year ago

Thanks. Had no idea parse_str did that :D

Philipp Kyeck Over a year ago

this creates a "notice" if REQUEST_URI doesn't contain a ?

ditto · Accepted Answer · 2015-02-15 12:04:22Z

3

$the_array = explode('/', trim($_SERVER['REQUEST_URI'], '/'));

answered Feb 15, 2015 at 12:04

ditto

6,41711 gold badges58 silver badges92 bronze badges

Comments

Adam Wright · Accepted Answer · 2011-04-01 13:01:26Z

1

Why not just use the $_GET dictionary?

answered Apr 1, 2011 at 13:01

Adam Wright

49.5k12 gold badges134 silver badges153 bronze badges

5 Comments

OMGKurtNilsen Over a year ago

Because I'm using mod_rewrite

Dan Lugg Over a year ago

If you're going after pretty URLs, often times all the querystring is compacted into directory levels; this/is/the/uri/path rather than this?is=the&uri=path. In the case of the former, in that you've rewritten it for prettiness, you can just explode('/', $uri) the REQUEST_URI

OMGKurtNilsen Over a year ago

TomcatExodus: I'm doing both. My urls are /controller/method/id, and then any additional vars as ?var=something

roberthuttinger Over a year ago

you can pass query strings with mod_rewrite using QSA flag

user109764 Over a year ago

I came here because for some reason $_GET and $_REQUEST where empty on my Wordpress while $_SERVER['REQUEST_URI'] was containing the required variables.

Collectives™ on Stack Overflow

PHP parse REQUEST_URI into array

4 Answers 4

2 Comments

2 Comments

Comments

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

2 Comments

Comments

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related