How can I pass DB connection object from one class to another?

Question

I'm trying to pass a PDO connection object from one class to another. But I'm not being very successfull. And I only want to instanciate only one PDO object.

With the help from dqhendricks and awm I managed to get the following solution working:

class Factory {

  function createUser($id = NULL) {
    return new User(Conn::get_conn(), $id);
  }  
  function createApplication($id = NULL) {
    return new User(Conn::get_conn(), $id);
  }
}

class Conn {
  private static $conn = NULL;

  private function __construct() {}

  private static function init() {
      $conf = self::config();
      try { 
        self::$conn = new PDO($conf['dsn'], $conf['user'], $conf['pass']);
      } 
      catch (PDOException $e) { 
        echo $e->getMessage(); 
      }
  }

  public static function get_conn() {
    if (!self::$conn) { self::init(); }
    return self::$conn;
  }

  private static function config($cfg_file = 'sl.config') {
    $config = parse_ini_file('/../'.$cfg_file);
    $conf = array();

    $conf['user']    = $config['db_user']; 
    $conf['pass']    = $config['db_password'];
    $conf['dsn']     = 'mysql:dbname='.$config['db_name'].';host='.$config['db_host'];

    return $conf;
  }  
}

In my UserDAO class, I can now do this:

class UserDAO {
  private $db;
  private $id;

  function UserDAO (&$db, $id) {
    $this->db = &$db;
    $this->id = &$id;
  }  

  public function getRows($sql)
  {   
    $result = $this->db->query($sql);
    $row = $result->fetch(PDO::FETCH_ASSOC);    
    return $row;            
  }

  function getUsers($limit = 10) {
    $sql ="SELECT * FROM sl_store LIMIT $limit";
    return $this->getRows($sql);
  }
}

//My User class
class User extends UserDAO implements iUser {}

// And to test it working:
$user1 = Factory::createUser('5');
$user2 = Factory::createApplication('7');

you don't get to return whatever you want from a constructor to determine what a new statement creates. a new statement always creates an object out of the named class. — dqhendricks
– dqhendricks, Commented Apr 2, 2011 at 1:59

awm · Accepted Answer · 2011-04-02 07:54:16Z

2

How about defining an abstract class which gives you the PDO object on request?

E.g.

abstract class Db {

  private static $x = null;

  private static function init() {
    try {
      self::$x = new PDO(...);
    } catch (PDOException $e) {
      ...
    }
  }

  public static function getX() {
    if (!self::$x) self::init();
    return self::$x;
  }
}

answered Apr 2, 2011 at 7:54

awm

6,59027 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Steven Over a year ago

Your soultion was better. Thanks :)

Steven Over a year ago

I was planning on using Dependency Injection, but have I ended up using Singelton pattern ?

awm Over a year ago

Wow, singleton pattern.... didn't even know it had a name! Cheers. :)

dqhendricks · Accepted Answer · 2011-04-02 01:57:59Z

1

no need to have your class create an instance of itself if all you want is an instance of a different object back. maybe make a static method in Conn to return an instance of a db connection.

class Conn {

    // prevent new statement
    private __construct() {}

    public static return_pdo() {
        blah
        blah
        blah
        return $db;
    }

    public static config($file) {
        do stuff
    }
}

then call statically

$pdo = Conn::return_pdo();

answered Apr 2, 2011 at 1:57

dqhendricks

19.2k11 gold badges54 silver badges88 bronze badges

Comments

tmg · Accepted Answer · 2011-04-01 23:52:59Z

0

It's because new Conn() returns $Conn object, not the value from $Conn->Conn() method. Try this:


class Conn{
 function Conn() {
   $db = new PDO($conf['dsn'], $conf['user'], $conf['pass']);
 }
 function get_db() {
     return $this->db;
 }
}

class Factory {
  function createUser($id = NULL) {
    $new_conn = new Conn();
    $db = $new_conn->get_db();
  }
}

answered Apr 1, 2011 at 23:52

tmg

8726 silver badges7 bronze badges

Collectives™ on Stack Overflow

How can I pass DB connection object from one class to another?

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related