set NODE_ENV variable in production via docker file

Question

I am trying to use below code below code in nodejs

if (process.env.NODE_ENV !== 'production')

I tried to set NODE_ENV variable from docker file like below.

FROM collinestes/docker-node-oracle:10-slim
ENV NODE_ENV=production
EXPOSE  8085
CMD ["npm","start"]

If i to run my docker image it does not start and throws error. If i remove NODE_ENV all runs fine. Is it the right way to setting NODE_ENV from dockerfile?

What is the error?

djheru
– djheru

2019-03-20 18:58:43 +00:00
Commented Mar 20, 2019 at 18:58 — djheru
– djheru, Commented Mar 20, 2019 at 18:58

Cody Swann · Accepted Answer · 2019-03-20 17:26:02Z

16

Remove the equal sign

ENV NODE_ENV production

answered Mar 20, 2019 at 17:26

Cody Swann

7776 silver badges9 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Hacker Over a year ago

But i have other variables like ENV UV_THREADPOOL_SIZE=5 which does not have any issue.

Mostafa Hussein Over a year ago

Syntax is not the problem in this case, ENV supports both styles as shown in here: docs.docker.com/engine/reference/builder/#env

Mostafa Hussein · Accepted Answer · 2019-03-20 18:23:12Z

4

Your Dockerfile should work, are you sure there isn't anything else inside the application, maybe package.json could be override it ?

I have tested it and it works correctly

$ echo $NODE_ENV
production

Also I would suggest to set the NODE_ENV variable while running the container as it would be easier to modify, I am aware that you can override it anyway if needed but setting it on the run-time will make your image with less layers. you can use the command below

-e can be used to pass an environment variable and can be passed multiple times if you have more than one variable

docker run -e NODE_ENV=production $IMAGENAME

edited Mar 20, 2019 at 18:23

answered Mar 20, 2019 at 17:45

Mostafa Hussein

12.2k3 gold badges43 silver badges65 bronze badges

8 Comments

Hacker Over a year ago

npm start has babel-node --presets es2015 index.js and when i have that variable in docker file it throws up error like babel-node not found

Mostafa Hussein Over a year ago

So maybe you need to configure PATH to make it work. This is just my guessing as I don't know more information about your actual Dockerfile

Hacker Over a year ago

If i use prod instead of production, it works fine.

Mostafa Hussein Over a year ago

So it seems your application uses prod not production, am i correct ?

Hacker Over a year ago

Yeah. So i had to change my code also top prod. If i use production in dockerfile, it does not work.

|

Collectives™ on Stack Overflow

set NODE_ENV variable in production via docker file

2 Answers 2

2 Comments

8 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

8 Comments

Your Answer

Sign up or log in

Post as a guest

Related