changing table td color based on a variable value

Question

i am trying to change the color of a td element in a table based on the statusID. status can be either zero or one. I wanna show the td as red if it its status is zero and green if status is one. my code doesn't work. I am getting the status of the device to a variable calle $statusDevice. any suggestions are welcomed.

$colors = [ '#FF0000',' #008000'];

$conn= mysqli_connect( $dbhost, $dbuser, $dbpass, $db ) or die("Could not connect: " .mysqli_error($conn) );
$sql = "SELECT Name FROM parameter WHERE Device='A'";
if($result = mysqli_query($conn, $sql)){
  if(mysqli_num_rows($result) > 0){

    echo '<table>';

    while($row = mysqli_fetch_array($result)){

      $bgColor= $colors[$statusDevice];
      echo $bgColor;
      //echo $colors[0];

      echo '<tr><th>Status of Device</th>';

      echo '<td bgcolor= $bgColor); >' . $row['A']. '</td></tr>';

      echo $bgColor;

    }echo "</table>";
  }

<div style="background-color:<?=(($status%0)?'red':'yellow');?>;">blah</div> — Chris S.
– Chris S., Commented Mar 26, 2019 at 14:34
Also do not put variables in single ticks. Check your source code. You'll figure out they are not being evaluated to their value that way. — Chris S.
– Chris S., Commented Mar 26, 2019 at 14:35
bgcolor is deprecated. Instead use style as @ChrisS. suggested — RiggsFolly
– RiggsFolly, Commented Mar 26, 2019 at 14:36

Benjie Wheeler · Accepted Answer · 2019-03-26 14:37:51Z

1

Use double quotes " not single ' quotes to interprete variables in strings.

change this line

  echo '<td bgcolor= $bgColor); >' . $row['A']. '</td></tr>';

to this:

  echo "<td bgcolor= $bgColor; >" . $row['A']. '</td></tr>';

And I think you have an extra parenthesis in your code (I fixed it)

Besides bgcolor is deprecated you should use style instead like So:

  echo "<td style='background-color: $bgColor;'>" . $row['A']. '</td></tr>';

edited Mar 26, 2019 at 14:37

answered Mar 26, 2019 at 14:34

Benjie Wheeler

5754 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

RiggsFolly Over a year ago

Small Note See this comment

Maksim · Accepted Answer · 2019-03-26 14:37:00Z

0

You need to concatinate varibles with string:

echo '<td bgcolor= '.$bgColor.'>' . $row['A']. '</td></tr>';

Or use " instead of '

answered Mar 26, 2019 at 14:37

Maksim

2,9672 gold badges20 silver badges33 bronze badges

3 Comments

Chris S. Over a year ago

not sure which is more oooooldschool, using td or using the deprecated attribute bgcolor

Maksim Over a year ago

Here is question answer, not programmin school :) I code like this at start - it normal IMHO. He will study for normal coding in process.

Chris S. Over a year ago

Not offending. Just pointing out you're using things that are likely to be removed from browsers and stop working anytime soon, if not already removed (bgcolor). Don't get me wrong there.

Sethu · Accepted Answer · 2019-03-26 14:40:58Z

0

FYI, bgcolor is deprecated so just use this

echo '<td style= "background-color:'.$bgColor.';" >' . $row['A']. '</td></tr>'

instead of

answered Mar 26, 2019 at 14:40

Sethu

1,37912 silver badges14 bronze badges

Collectives™ on Stack Overflow

changing table td color based on a variable value

3 Answers 3

1 Comment

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related