JavaScript Regex Help!

Question

I am trying to match a @ tags within this string:

 @sam @gt @channel:sam dfgfdh sam@sam

Now in regex testers this works @[\S]+ (with settings on JS testing) to pick out all strings starting with @ so in them I get:

@sam @gt @channel:sam @sam

But then in browsers using this code:

function detect_extractStatusUsers(status){
var e = new RegExp('@[\S]+', 'i');
m = e.exec(status);
var s= "";

if (m != null) {
    for (i = 0; i < m.length; i++) {
        s = s + m[i] + "\n";
    }
    alert(s);
}

return true;
}

I can only get one single match of @ (if I'm lucky, normally no match).

I must be missing something here and my eyes have just been looking at this for too long to see what it is.

Can anyone see what's wrong in this function?

Thanks,

mVChr · Accepted Answer · 2011-04-04 12:11:35Z

6

You need to:

use the global search g setting
escape your \
use match instead of exec

var e = new RegExp('@[\\S]+', 'gi');

m = status.match(e);

edited Apr 4, 2011 at 12:11

answered Apr 4, 2011 at 11:58

mVChr

50.3k11 gold badges111 silver badges105 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Sammaye Over a year ago

Hmm it don't work, it still only picks out @s from @sam calling that exact function (with the added g flag) like: detect_extractStatusUsers("@sam");

mVChr Over a year ago

I updated my answer addressing other issues in your functionality.

Sammaye Over a year ago

Woo cheers, I knew it was something simple. Full points given :D

Martijn · Accepted Answer · 2011-04-04 12:33:15Z

1

You need to call exec repeatedly, until it returns null. Each time it will return a match object, containing all the captures for that match.

I've taken the liberty of rewriting your function the way I would have written it:

function detect_extractStatusUsers(status){
    var rx = /(@[\S]+)/gi,
        match,
        tags = [];
    while (match = e.exec(status)) {
        tags.push(match[1]);
    }
    if (tags.length > 0) {
        alert(tags.join('\n'));
    }
}

answered Apr 4, 2011 at 12:33

Martijn

13.7k4 gold badges50 silver badges60 bronze badges

Collectives™ on Stack Overflow

JavaScript Regex Help!

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related