How to replace multiple links with multiple dynamic url using jquery each loop?

Question

I have multiple headings with mysite.com internal links like below:

Article 1 https://externalsite1.com/url1

Article 2 https://externalsite2.com/url2

Article 3 https://externalsite3.com/url3

I need to replace all the articles internal site links to their below external sites urls

I have tried this at here: http://jsfiddle.net/n4hwjrsq/2/ but no luck, please help me

$("a").each(function() {
  var external_link = $("div.ptb_original_link").text(); 
  $(this).attr('href',$(this).attr('href').replace('',external_link)); 
});

I expect the output with externalsite links like below :

Article 1 https://externalsite1.com/url1

Article 2 https://externalsite2.com/url2

Article 3 https://externalsite3.com/url3

APAD1 · Accepted Answer · 2019-04-08 19:31:28Z

You need to be more specific with your external_link variable, otherwise you're just going to end up with every URL in every link:

$("a").each(function() {
  var external_link = $(this).parent().parent().next("div.ptb_original_link").text();
  $(this).attr('href', external_link);
});

<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
<div class="ptb_title">
  <h2 class="entry_title"><a href="https://example.com/link1">Article 1</a></h2>
</div>
<div class="ptb_original_link">https://externalsite1.com/url1</div>
<br>
<div class="ptb_title">
  <h2 class="entry_title"><a href="https://example.com/link2">Article 2</a></h2>
</div>
<div class="ptb_original_link">https://externalsite2.com/url2</div>
<br>
<div class="ptb_title">
  <h2 class="entry_title"><a href="https://example.com/link3">Article 3</a></h2>
</div>
<div class="ptb_original_link">https://externalsite3.com/url3</div>
<br>

Ashkan Mobayen Khiabani · Accepted Answer · 2019-04-08 19:47:45Z

1

$(".entry_title a").each(function() {
  $(this).attr('href',$(this).closest('div').next().html()); 
});

Or to make sure if there might be other divs before the one with external link:

$(".entry_title a").each(function() {
  $(this).attr('href',$(this).closest('div').next('.ptb_original_link').html()); 
});

Demo

edited Apr 8, 2019 at 19:47

answered Apr 8, 2019 at 19:30

Ashkan Mobayen Khiabani

34.4k35 gold badges112 silver badges187 bronze badges

Collectives™ on Stack Overflow

How to replace multiple links with multiple dynamic url using jquery each loop?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related