How to fix js code on if then statement with number Input

Question

I wanted the user to input a number and if the number is a multiple of 3 or 5, I want a word/paragraph that says, "You are a witch"

created a function but I cannot seem to make it work

var x;

function pop() {
  for (x = 1; x <= 100; x++)
    if (x % 3 == 0) {
      document.getElementById('onClick').innerHTML = 'You are a Warrior';
    } else if (x % 5 == 0) {
      document.getElementById('onClick').innerHTML = 'You are a wizard';
    } else if (x % 3 == 0 && x % 5 == 0) {
      document.getElementById('onClick').innerHTML = 'You are a Sage';
    } else {
      document.getElementById('onClick').innerHTML = 'invalid';
    }
}

<input type="number" id="x">
<br>
<br>
<center><button onclick="pop()">Click Me</button> </center>  
<br>
<br>
<p id="onClick"></p>

Get rid of the loop. Just set x to the contents of the text box. — 001
– 001, Commented Apr 10, 2019 at 21:46
by the way, your code does not accept input from a user, it loops 100 times overwriting a single elements content every time — Jaromanda X
– Jaromanda X, Commented Apr 10, 2019 at 21:47

001 · Accepted Answer · 2019-04-10 21:56:25Z

1

You never read the user input. You have a loop where there should not be one. You need to change the order of the comparisons.

function pop(){
    var x = document.getElementById("x").value;
    
    if (x % 3 == 0 && x % 5 == 0) {
        document.getElementById('onClick').innerHTML = "You are a Sage";
    }
    else if (x % 3 == 0 ) {
        document.getElementById('onClick').innerHTML = "You are a Warrior";
    }
    else if (x % 5 == 0){
        document.getElementById('onClick').innerHTML = "You are a wizard";
    }
    else {
        document.getElementById('onClick').innerHTML = "invalid";
    } 
}

<input type="number" id="x">
<br>
<br>
<center><button onclick="pop()">Click Me</button> </center>  
<br>
<br>
<p id="onClick"></p>

answered Apr 10, 2019 at 21:56

001

13.6k5 gold badges38 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How to fix js code on if then statement with number Input

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related