Java 8 Group by and append to a set

Question

I have function which returns a Map<String, Set<String>>, Code before java 8:

Map<String, Set<String>> degreeMap = new HashMap<>();
for(Course  course : courses){
    Set<String> cList = degreeMap.get(course.getCourseLevel().toString());
    if(Objects.nonNull(cList)){
        cList.addAll(course.getMasterDegree()); //this is what i want to append to the old set
        degreeMap.put(course.getCourseLevel().toString(), cList);
    } else{
        degreeMap.put(course.getCourseLevel().toString(), new HashSet<>(course.getMasterDegree()));
    }
} 
return degreeMap;

Which return a map of courselevel -> set of degrees.

For example, it read all the courses and return a map like:

{"undergraduate" : ["BTech", "BSc", "BE"],
"masters": ["MTech", "MBA"],
"Executive": ["PGDBM", "EECP"]}

Here is my Course class:

public class Course {
    private List<String> masterDegree;
    private CourseLevel courseLevel;
}

But I want to write this piece of code in Java 8 style. For that, I tried this:

Map<String, Set<String>> degreeMap = courses.stream().collect(
        Collectors.groupingBy(c -> c.getCourseLevel().toString(),
                Collectors.mapping(c -> c.getMasterDegree(), Collectors.toSet()))
);

which is not working and I am getting the following compile-time error on this:

no instance(s) of type variable(s) exist so that List conforms to String inference variable T has incompatible bounds: equality constraints: String lower bounds: List

Any suggestion, how to achieve this?

It sounds to me that you're looking for a flatMapping equivalent of Java-9 in an older version. — Naman
– Naman, Commented Apr 12, 2019 at 9:12
@GhostCat tried editing the question to be relevant enough. hope its clear now. — Naman
– Naman, Commented Apr 12, 2019 at 9:35
for(Course course : courses) degreeMap.computeIfAbsent(course.getCourseLevel() .toString(), x -> new HashSet<>()) .addAll(course.getMasterDegree()); By the way, even in your pre-Java 8 version, there never was a reason to put the same list into the Map again after addAll. — Holger
– Holger, Commented Apr 12, 2019 at 12:27

Naman · Accepted Answer · 2019-04-12 09:26:55Z

3

Not tested, but looks like, you're looking for something like:

    return courses.stream()
            .collect(Collectors.toMap(course -> course.getCourseLevel().toString(),
                    course -> new HashSet<>(course.getMasterDegree()),
                    (set1, set2) -> Stream.of(set1, set2)
                            .flatMap(Set::stream).collect(Collectors.toSet())));

answered Apr 12, 2019 at 9:26

Naman

32.7k32 gold badges240 silver badges385 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Holger Over a year ago

In this case, (set1, set2) -> { set1.addAll(set2); return set1; } clearly is the preferable merge function…

eancu · Accepted Answer · 2019-04-12 09:27:15Z

You might be interested in the Collectors.toMap() method.

Here is an example that you may need to tweak as I did not test it.

Map<String, Set<String>> degreeMap = courses.stream()
    .collect(
        Collectors.toMap(
            item -> item.getCourseLevel().toString(), //your key mapping
            item -> item.getMasterDegree(), //your value mapping
            (oldValue, newValue) -> { //your process of aggregation
                if (null == oldValue) {
                    return newValue;
                } else {
                    oldValue.addAll(newValue);
                    return oldValue;
                }
            },
            LinkedHashMap::new //your result initialiser
        )
    );

Also, another tip: you do not need to get by key and check for null, you can use the .compute(), .computeIfAbsent(), .computeIfPresent() methods on the map

qtopierw · Accepted Answer · 2019-04-12 09:20:59Z

-1

I don't think you need lamda expression, you should refactor your codes to make it clear instead.

        // supposed to be initialied with non-empty values
        // Map<String, Set<String>> degreeMap = ...

        for(Course  course : courses){
            // something like below
            String key = course.getCourseLevel().toString();
            // degreeSet should not be null
            Set<String> degreeSet = course.getMasterDegree();

            // TODO: check nullable
            degreeSet.putAll(degreeMap.get(key));

            degreeMap.put(key, degreeSet);
        } 

        return degreeMap;

answered Apr 12, 2019 at 9:20

qtopierw

1,55714 silver badges23 bronze badges

Collectives™ on Stack Overflow

Java 8 Group by and append to a set

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related