Mongoose findByIdAndUpdate doesnt update my mongoDB

Question

hello im new to nodejs and mongoose. im working on my web application and im trying to make mongoose findByIdAndUpdate which doesnt update my mongoDB, what am i doing wrong? im trying to update an exciting user details.

i tried many solutions to this problems like many querys but none of them work. im making post request with postman trying to change this fields : firstName lastName username email phone to the route : http://localhost:5000/api/users/5cbb60157b07f13ec88070c4

but im always getting the old user and not the updated user as response

api/users :
const express = require('express');
const router = express.Router();
const User = require('../../models/User');
const bcrypt = require('bcryptjs');
const validateCreateUserInput = require('../../validation/createUser');
const passport = require('passport');

router.post('/:id', passport.authenticate('jwt', { session: false }), (req, res) => {
  const userDetails = {};
  if (req.body.firstName) userDetails.firstName = req.body.firstName;
  if (req.body.lastName) userDetails.lastName = req.body.lastName;
  if (req.body.username) userDetails.username = req.body.username;
  if (req.body.email) userDetails.email = req.body.email;
  if (req.body.phone) userDetails.phone = req.body.phone;
  User.findByIdAndUpdate(
    { _id: req.params.id },
    { new: true },
    { $set: userDetails })
    .then(user => {
      res.json(user)
    })
    .catch(err => console.log(err));
})

module.exports = router;

User model :

const mongoose = require('mongoose');
const Schema = mongoose.Schema;

const UserSchema = new Schema({
  firstName: {
    type: String,
    required: true
  },
  lastName: {
    type: String,
    required: true
  },
  username: {
    type: String,
    required: true
  },
  password: {
    type: String,
    required: true
  },
  email: {
    type: String,
    required: true
  },
  phone: {
    type: String,
    required: true
  },
  createdAt: {
    type: Date,
    default: Date.now
  },
  updatedAt: {
    type: Date,
    default: Date.now
  }
})

module.exports = User = mongoose.model('users', UserSchema);

i expect the data to change in the mongoDB

Wai Ha Lee · Accepted Answer · 2019-04-21 14:03:11Z

1

It will work if you change the code as follows. The "$set" statement used in the Mongodb Shell operation is not used with "Mongoose".

 User.findByIdAndUpdate(
  { _id: req.params.id },
  userDetails,
  { new: true })
 .then(user => {
  res.json(user)
  })
 .catch(err => console.log(err));
  })

edited Apr 21, 2019 at 14:03

Wai Ha Lee

8,856102 gold badges61 silver badges100 bronze badges

answered Apr 21, 2019 at 3:45

Rıdvan Can

995 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

krbalaji · Accepted Answer · 2019-04-21 05:34:20Z

0

You can use 'update' method when you use $set. Example:

User.update({
_id: Schema.Types.ObjectId(req.params.id)
},{
Key: value
})

answered Apr 21, 2019 at 5:34

krbalaji

4745 silver badges12 bronze badges

Collectives™ on Stack Overflow

Mongoose findByIdAndUpdate doesnt update my mongoDB

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related