How to properly handle error from json response

Question

First off I am total noob when it comes to writing python so a lot of what I've done thus far has been all learn as I go so with that said:

I have this bit of code here

if buycott_token != '':
    print("Looking up in Buycott")
    url = "https://www.buycott.com/api/v4/products/lookup"
    headers = {
    'Content-Type': 'application/json'
    }
    data={'barcode':upc,
          'access_token':buycott_token
         }
    try:
        r = requests.get(url=url, json=data, headers=headers)
        j = r.json()
        if r.status_code == 200:
        print("Buycott found it so now we're going to gather some info here and then add it to the system")
        name = j['products'][0]['product_name']
        description = j['products'][0]['product_description']
        #We now have what we need to add it to grocy so lets do that
        #Sometimes buycott returns a success but it never actually does anything so lets just make sure that we have something
        if name != '':
            add_to_system(upc, name, description)
    except requests.exceptions.Timeout:
        print("The connection timed out")
    except requests.exceptions.TooManyRedirects:
        print ("Too many redirects")
    except requests.exceptions.RequestException as e:
        print e

98% of the time this works just fine with no issues. Then I'll scan something with my barcode scanner and I'll get

Traceback (most recent call last):
  File "./barcode_reader.py", line 231, in <module>
    increase_inventory(upc)
  File "./barcode_reader.py", line 34, in increase_inventory
    product_id_lookup(upc)
  File "./barcode_reader.py", line 79, in product_id_lookup
    upc_lookup(upc)
  File "./barcode_reader.py", line 128, in upc_lookup
    name = aj['products'][0]['product_name']
KeyError: 'products'

I am certain that it has something to do with how the json is being returned. Problem is when this is thrown it kills the script and that is that. Thank you for your assistance.

You should print the value of j. The error is telling you it doesn't have a 'products' key at the top level — Daniel Roseman
– Daniel Roseman, Commented Apr 27, 2019 at 16:47
You should check if 'products ' is there in the response and then fetch the name. — Nithin
– Nithin, Commented Apr 27, 2019 at 16:49

niekas · Accepted Answer · 2019-04-27 16:57:52Z

1

The problem is that there is no 'products' key in your response JSON. The workaround could be providing a default value if a 'products' key is not present:

default_value = [{'product_name': '', 'product_description': ''}]
j.get('products', default_value)[0]['product_name']

or you could simply check whether your response has the products key:

if 'products' not in j:
    return 'Product not found'

edited Apr 27, 2019 at 16:57

answered Apr 27, 2019 at 16:50

niekas

9,2577 gold badges46 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Daniel Butler Over a year ago

This would be the problem essentially you are trying to look up something that doesn’t exist in the dictionary

Dhruv Rajkotia · Accepted Answer · 2019-04-27 16:52:24Z

0

I think this error is because of API doesn't give you proper json in response. So I think you can check from your side if key is in API response or not.

if 'products' in j:
   name = j['products'][0]['product_name']
   description = j['products'][0]['product_description']
else:
   #Whatever you want when 'product' is not in API response

answered Apr 27, 2019 at 16:52

Dhruv Rajkotia

3802 silver badges8 bronze badges

Collectives™ on Stack Overflow

How to properly handle error from json response

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related