each loop in ruby not working

Question

I have a very simple each loop written in Ruby :

params[:category].each do |i|
  cat = Category.find(i)
  string << cat.name
end

The strange issue is that it only ever runs through this loop once!

params[:category] should be an array of params that all came in under the category label, right?

this was generated using a select tag in the controller:

<%=select_tag "category", options_from_collection_for_select(@category,"id" , "name"),:multiple => true, :class=>"bbFormSelect",:id=>"select_category", :name => "category" %>

Let me know if you see what's wrong!

ps. params[:category] will result in a length larger than 1, correctly. — mtay
– mtay, Commented Apr 8, 2011 at 1:30
What does string have, and what did you expect it to have? — Andrew Grimm
– Andrew Grimm, Commented Apr 8, 2011 at 1:48

DanneManne · Accepted Answer · 2011-04-08 01:42:50Z

6

You can always inspect the content of a variable by manually logging it like this:

logger.info(params[:category])

That will work from all Controllers.

But I would recommend you to go by this in a different way. With your approach the controller will call the database once for every category supplied. It should be enough to send it to the find method like this:

@categories = Category.find(params[:category])
names = @categories.map(&:name).join

If the find method gets an array of ids instead of just an id, it will return an array of categories.

answered Apr 8, 2011 at 1:42

DanneManne

21.2k5 gold badges60 silver badges58 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Spyros · Accepted Answer · 2011-04-08 01:37:08Z

3

Use <%= debug params[:category] %> somewhere in your view to see what the contents of the posted params are. If the loop runs once, then there is one entry in the categories.

Other than that the loop seems fine (string should be initialized before, i suppose you have that since you get no error).

answered Apr 8, 2011 at 1:37

Spyros

49k26 gold badges95 silver badges134 bronze badges

Comments

Jesse Wolgamott · Accepted Answer · 2011-04-08 01:44:53Z

1

If you want Rails to build you an array of categories from the input parameters, change the name of your input to be category[], like so:

<%=select_tag "category", options_from_collection_for_select(@category,"id" , "name"),:multiple => true, :class=>"bbFormSelect",:id=>"select_category", :name => "category[]" %>

answered Apr 8, 2011 at 1:44

Jesse Wolgamott

40.3k4 gold badges86 silver badges109 bronze badges

Collectives™ on Stack Overflow

each loop in ruby not working

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related