Checking regex in rails TestCase

Question

So in Rails I've written these validations for an email :

validates :email, presence: true, uniqueness: true
validates_format_of :email, :with => /\A[^@\s]+@([^@\s]+\.)+[^@\s]+\z/

When I try to submit something with a wrong email this works because it sends me an error, but when I try to test it like this :

test "should not save if email is not valid" do
    slogan = Slogan.create(firstname: 'tristan', lastname: 'vermeesch', email: 'titivermeeschgmail.com', slogan: 'Test')
    assert slogan.valid?, "Tried to save with an email that is not valid"
  end

The test fails, can someone please help?

What are you trying to test in the 2nd scenario? The error message? — asimhashmi
– asimhashmi, Commented Jun 6, 2019 at 10:43
I'm testing that an invalid email shouldn't be saved @AsimHashmi — Tristan Vermeesch
– Tristan Vermeesch, Commented Jun 6, 2019 at 10:45

asimhashmi · Accepted Answer · 2019-06-06 11:02:06Z

2

If you are trying to test that your model should not be saved and it should have errors when wrong email is given, you can use the valid? method and error? property. Your test would be like this:

test "should not save if email is not valid" do
    slogan = Slogan.create(firstname: 'tristan', lastname: 'vermeesch', email: 'titivermeeschgmail.com', slogan: 'Test')
    assert_not_nil slogan.errors[:email]
  end

edited Jun 6, 2019 at 11:02

answered Jun 6, 2019 at 10:53

asimhashmi

4,3861 gold badge17 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Mark Merritt Over a year ago

This looks like you are testing the same thing twice...maybe remove assert_equal slogan.valid?, false?

Collectives™ on Stack Overflow

Checking regex in rails TestCase

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related