Powershell foreach and export-csv doesn't work

Question

I use powershell V3 and / or powershell V4 it's been a few days since I'm on this issue but no solution so far.

I explain, I have a vulgar powershell with an input file (list of servers) on which I wish to apply a treatment via a loop foreach and, retrieve the output in a csv.

The loop seems to work however, on an input file of 100 lines only the last one is export (the previous occurrences are overwritten) why I do not know. I have already tried to readjust the script by adding variables for incrementation (see code if below) but without success.

Can you help my to salve this case please

enter code here Code1
                                            # Emplacement fichierSource
                        $fileComputerNames = "E:\ReportXplanif\ServeursIUCR2K12.txt"
                        # Write-Host $fileComputerNames

                        # Emplacement fichierDestination
                        $desti = "E:\ReportXplanif"
                        # Write-Host $desti

                        Foreach ($server in Get-Content $fileComputerNames) {


                            $cmde = {Get-ScheduledTask | Where {$_.Principal.userid -eq "ZRES\XPLANIF"} | Get-ScheduledTaskInfo}
                            Invoke-Command -ComputerName $server -ScriptBlock $cmde |
                            Select @{LABEL='Serveur';EXPRESSION={$server}}, TaskName,LastRunTime,NextRunTime
                            }
                           Export-csv ($desti + "\XplanifTasks.csv") -Delimiter "," -NoTypeInformation


                    code2
                    # Emplacement fichierSource
                    $fileComputerNames = "E:\ReportXplanif\ServeursIUCR2K12.txt"
                    # Write-Host $fileComputerNames

                    # Emplacement fichierDestination
                    $desti = "E:\ReportXplanif\"
                    # Write-Host $desti

                    $cmde = @()
                    Foreach ($server in Get-Content $fileComputerNames) {


                        $cmde += {Get-ScheduledTask | Where {$_.Principal.userid -eq "ZRES\XPLANIF"} | Get-ScheduledTaskInfo}
                        Invoke-Command -ComputerName $server -ScriptBlock $cmde |
                        Select @{LABEL='Serveur';EXPRESSION={$server}}, TaskName,LastRunTime,NextRunTime
                        }`enter code here`

                        $cmde | Export-csv ($desti + "\XplanifTasks.csv") -Delimiter "," -NoTypeInformation`enter

It is because you are not appending to ($desti + "\XplanifTasks.csv"), you are overwriting it with the last line in your script. Try doing with Export-csv ($desti + "\XplanifTasks.csv") -Append -Delimiter "," -NoTypeInformation`enter — Iggy Zofrin
– Iggy Zofrin, Commented Jun 18, 2019 at 23:19
There is more than just the append that is wrong in this code. The Export-CSV doesn't have any data piped to it and it doesn't look to have the right syntax to initiate the loop. e.g. Foreach ($server in (Get-Content $fileComputerNames)) { — Drew
– Drew, Commented Jun 19, 2019 at 2:01

Scripticated · Accepted Answer · 2019-06-19 03:12:00Z

There are a few things funny with the code as it stands.

It appears as though your building an array $cmde of script blocks. Adding one script block for every Server in $fileComputerNames, even though those script blocks are not Server specific. (Does Invoke-Command even accept an array of script blocks? I would expect it to error out)
Your then piping this $cmde to Export-CSV
While there is nothing wrong with building an array using += its very inefficient in PowerShell and should be avoided if the array will be Large as it will significantly slow down your script.

I cannot fully vet what your trying to do but assuming your Invoke Command Does what you want on one computer something like the following should work for you.

...
$cmde = {Get-ScheduledTask | Where {$_.Principal.userid -eq "ZRES\XPLANIF"} | Get-ScheduledTaskInfo}
$SchTasks = Foreach ($server in Get-Content $fileComputerNames) {
    Invoke-Command -ComputerName $server -ScriptBlock $cmde |
    Select @{LABEL='Serveur';EXPRESSION={$server}}, TaskName,LastRunTime,NextRunTime
}

$SchTasks | Export-csv ($desti + "\XplanifTasks.csv") -Delimiter "," -NoTypeInformation

TheMadTechnician · Accepted Answer · 2019-06-19 17:51:55Z

I would be very tempted to use the Task Scheduler com object to do this so that I didn't have to create remote sessions on all of the computers, just connect to their task scheduler service. This does require that you enable remote management of scheduled tasks in the firewall, but if you're allowing remote powershell you probably allow this as well.

$Scheduler = New-Object -ComObject Schedule.Service
Get-Content $fileComputerNames -PipelineVariable 'Server' |ForEach-Object{
    $i=0
    # Try to connect to remote task scheduler up to 3 times
    While(!$Scheduler.Connect($Server) -eq 0 -or $i -eq 3){$i++}
    # If we aren't connected to the right server throw a warning and move on to the next server
    If(!$Scheduler.TargetServer -eq $Server){Write-Warning "Unable to connect to $Server"; Continue}
    $RootFolder = $Scheduler.GetFolder('\')
    $RootFolder.GetTasks(1) | # The '1' indicates we want to include hidden tasks
        Where {$_.Principal.userid -eq "ZRES\XPLANIF"} |
        Select @{LABEL='Serveur';EXPRESSION={$server}}, Name, LastRunTime, NextRunTime
} | Export-Csv "$desti\XplanifTasks.csv" -Del ',' -NoType

Collectives™ on Stack Overflow

Powershell foreach and export-csv doesn't work

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related