How to check argument equality with '*' wildcard in Bash? [duplicate]

Question

I'm new to bash scripting and I'm writing a script to automatically make a newly created .sh file executable. As such, I would want to check if .sh is preceded by the only argument provided in order to ensure a valid filename.

However, I'm getting a [: too many arguments error when I run ./createExecutableScript.sh asd.sh.

Initially, I thought it was because $1 was not wrapped in " that caused the error, and therefore added the "s in.

I also referred to this question (Linux Shell Script - String Comparison with wildcards) and added the *s outside of the "s.

#!/bin/bash

if [ "$#" -eq 1 ] && [ "$1" == *".sh" ]
then
    echo "Creating file with name: $1"
else
    echo "Invalid or missing filename!"
fi

Shellcheck tells you what the problem is. Also see How to use Shellcheck, How to debug a bash script? (U&L.SE), How to debug a bash script? (SO), How to debug bash script? (AskU), Debugging Bash scripts, etc. — jww
– jww, Commented Jun 23, 2019 at 8:07

Erez Ben Harush · Accepted Answer · 2019-06-23 07:58:44Z

2

The answer in Linux Shell Script - String Comparison with wildcards is correct, you need to have double brackets like this:

#!/bin/bash

if [ "$#" -eq 1 ] && [[ "$1" == *".sh" ]]
then
    echo "Creating file with name: $1"
else
    echo "Invalid or missing filename!"
fi

answered Jun 23, 2019 at 7:58

Erez Ben Harush

87710 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

zeng Over a year ago

Ah, I got careless there. Marked this question as duplicate. Thanks!

deosha · Accepted Answer · 2019-06-23 07:58:06Z

-1

So there is no variable as 1. You can do something like a=$1 and then put $a in the if statement. What you need is $($1) and not $1

answered Jun 23, 2019 at 7:58

deosha

9925 silver badges20 bronze badges

1 Comment

that other guy Over a year ago

In OP's example, $1 will correctly be asd.sh

Collectives™ on Stack Overflow

How to check argument equality with '*' wildcard in Bash? [duplicate]

2 Answers 2

1 Comment

1 Comment

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Linked

Related