Sequelize is not returning queryAsync object

Question

I'm building up nodejs api by using async await.So my controller every function is async which receives a promise by model. For query i have used the sequelize package for interacting with the database. for using sequelize async query behaviour i choose the bluebird plugin for promisfy.

Promise.promisifyAll(sequelize)

In my model i have write a method which return data but when i call the sequelize.query it will return the data but when i write sequelize.queryAsync it should not return the data. The function is exist when i print the sequelize object. I want to know how to get the queryAsync data.

LeadModel.getActiveRecords = function () {
  return new Promise(async (resolve, reject) => {
    try {
      let output = await LeadModel.sequelize.queryAsync("SELECT * FROM some_tbl where status = '1'")
      // This below query is working fine without queryAsync
      //let output = await LeadModel.sequelize.query("SELECT * FROM some_tbl where status = '1'")
      resolve(output)
    } catch (e) {
      reject(e)
    }d
  })
}

In the controller i'm using this way.

LeadController.getlead = async function(req, res) {
    try {
        let datanew = await LeadModel.getActiveRecords();
        console.log(datanew);
    } catch (e) {
        throw e;
    }
}

Can you please help me out why the sequelize is not return async query result.

sequelize.query returns a promise, no need to promisifyAll it. — tkausl
– tkausl, Commented Jun 23, 2019 at 17:41
It requires promisifyAll because i used var Promise = require('bluebird') Promise.promisifyAll(sequelize) . It will add the async feature in all queries. — truesource
– truesource, Commented Jun 24, 2019 at 4:57

grimurd · Accepted Answer · 2019-06-24 21:09:14Z

1

What you're doing is completely unneccessary. You're returning a new promise that wraps a async function(async functions always return promises, thats how they work). And in that function you're calling sequelize query method which already returns a promise.

Also using promisifyAll on sequelize is completely unneccessary and redundant since sequelize is already async and you can use most methods with async/await.

This would do the exact same thing you're doing:

LeadModel.getActiveRecords = function() {
    return LeadModel.sequelize.query("SELECT * FROM some_tbl where status = '1'");
}

// Or you can do it in a single line
LeadModel.getActiveRecords = () => LeadModel.sequelize.query("SELECT * FROM some_tbl where status = '1'");

And to use it in the controller:

LeadController.getlead = async function(req, res, next) {
    try {
        let datanew = await LeadModel.getActiveRecords();
        console.log(datanew);
    } catch (e) {
        console.log(e);
        return next(err);
    }
}

answered Jun 24, 2019 at 21:09

grimurd

2,8701 gold badge26 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

truesource Over a year ago

thanks @grimurd. Now i get it that sequelize is already returns a promise so we don't need to write extra code.

Collectives™ on Stack Overflow

Sequelize is not returning queryAsync object

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related