If string includes words in array, remove them

Question

I have a string, and a list of words in an array.

What I want to do is say "If any words in this array are in the string, remove them" and then "remove an double spaces from the string"

I'm almost there, but for some reason it's not paying attention to the dash

const name = "My Awesome T-Shirt Something Else"    ;
    const words = [
          'V-Neck ',
          'Long Sleeve ',
          'T-Shirt ',
          'Pullover Hoodie ',
          'Raglan Baseball Tee ',
          'Tee ',
          'Zip Hoodie ',
          'Tank Top ',
          'Premium ',
          'Sweatshirt ',
          'PopSockets Grip and Stand for Phones and Tablets ',
          'Shirt '
        ];
        
    let newName = name;
    
         
    words.forEach(w => {
       if(name.includes(w)) newName = name.replace(w, '');
    });
    
    newName = newName.replace(/ +(?= )/g,'');
    
    console.log(newName)

This returns My Awesome T-Something Else

Nina Scholz · Accepted Answer · 2019-06-27 12:33:12Z

5

You are replacing name and not newName.

const name = "My Awesome T-Shirt Something Else"    ;
const words = [
      'V-Neck ',
      'Long Sleeve ',
      'T-Shirt ',
      'Pullover Hoodie ',
      'Raglan Baseball Tee ',
      'Tee ',
      'Zip Hoodie ',
      'Tank Top ',
      'Premium ',
      'Sweatshirt ',
      'PopSockets Grip and Stand for Phones and Tablets ',
      'Shirt '
    ];

let newName = name;


words.forEach(w => {
   while (newName.includes(w)) newName = newName.replace(w, ''); // take a while for more than one occurences
   //     ^^^^^^^                        ^^^^^^^
});

newName = newName.replace(/ +(?= )/g,'');

console.log(newName)

edited Jun 27, 2019 at 12:33

answered Jun 27, 2019 at 12:30

Nina Scholz

388k26 gold badges367 silver badges417 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

ceving Over a year ago

Same applies to the if condition. It is bad style to check name, if you deal with newName.

Collectives™ on Stack Overflow

If string includes words in array, remove them

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related