Fs not saving file correctly and how to simplify this code

Question

So I want to save the titles array formatted with line breaks and index of each element.

When I save the 'formatted' object with fs all I get in the file is 'undefined'.

Also, this code is probably really messy and could be simplified, what should I change?

            const $ = cheerio.load(body);
            let titles = [];
            $('div.collection.clearfix').each((i, el) => {
                const title = $(el)
                    .text()
                    .replace(/\n/g, '')
                    .trim()
                    .replace(/ /g, ',');
                titles.push(title);
            })

            let formatted = titles.forEach((i, title) => {
                return title + '. ' + i + '\n'
            });
            fs.writeFile('titles.txt', formatted, (e) => {
                if (e) console.error(e)
            })

EDToaster · Accepted Answer · 2019-07-24 23:10:49Z

3

You expect

            let formatted = titles.forEach((i, title) => {
                return title + '. ' + i + '\n'
            });

to return an array.

However, forEach returns undefined.

You are looking for titles.map, which returns an array. Then, you can join all the elements using Array.prototype.join() to turn it into a single string

answered Jul 24, 2019 at 23:10

EDToaster

3,1803 gold badges18 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Fs not saving file correctly and how to simplify this code

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related