values from a foreach loop in a function into an array

Question

I have a function that replaces PackageID in a SCCM task sequence, I would like to capture all those package IDs into a variable, so I would be able to create a report based on that.

The problem is that I already have a foreach loop doing the work, and I can't figure out how to not overwrite the values.

$Driver.PackageID comes from a foreach loop based on $Drivers, which contains

If I run the code I get this as I have Write-Output defined:

Updated code:

function Set-Drivers{

    foreach ($Driver in $Drivers) {

    Write-Output "Driver Name: $($Driver.Name)"
    Write-Output "DriverPackageID: $($Driver.PackageID)"
    }
}


$array = @()
$array = Set-Drivers
$hash = [ordered]@{

'DriverName'           = $Driver.Name
'DriverID'           = $Driver.PackageID
}

$array += New-Object -Typename PSObject -Property $hash

Can someone explain, why I only get the first result in my $array? I can see the values are being overwritten if I run it in debug mode.

you are setting the array to blank in EVERY LOOP. [grin] this $global:array = @() needs to be outside your foreach. — Lee_Dailey
– Lee_Dailey, Commented Aug 24, 2019 at 18:34
What Lee said. Also, do not modify global variables in a function or append to an array in a loop. What you want to do is simply output the objects in the loop (write your status output to the host or the verbose stream instead of the default stream), and then run $array = Set-Drivers in the global scope. — Ansgar Wiechers
– Ansgar Wiechers, Commented Aug 24, 2019 at 18:43
Still only get one result, do you have a suggestion how else it could be done ? — BenDK
– BenDK, Commented Aug 24, 2019 at 18:47
@BenDK - please post your current code since your comment doesn't tell us anything about what may be going wrong ... [grin] — Lee_Dailey
– Lee_Dailey, Commented Aug 24, 2019 at 18:55

EyuelDK · Accepted Answer · 2019-08-24 19:28:55Z

1

Your code is not iterating over the results, but instead only using one of them. This what you intended.

$array = $drivers | foreach { 
  [ordered]@{
    DriverName = $_.Name
    DriverID   = $_.PackageID
  }
}

answered Aug 24, 2019 at 19:28

EyuelDK

3,2392 gold badges21 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Theo · Accepted Answer · 2019-08-24 19:29:02Z

0

Your function doesn't return anything. It only writes lines to the console. Then after the function is finished, you create a single object and add that to your array.

Try something like

function Set-Drivers{
    $result = foreach ($Driver in $Drivers) {
        [PsCustomObject]@{
            'DriverName'  = $Driver.Name
            'DriverID'    = $Driver.PackageID
        }
    }
    # output the result 
    # the comma wraps the result in a single element array, even if it has only one element.
    # PowerShell 'flattens' that upon return from the function, leaving the actual resulting array.
   ,$result
}

$array = Set-Drivers

# show what you've got
$array

answered Aug 24, 2019 at 19:29

Theo

61.9k8 gold badges28 silver badges48 bronze badges

Collectives™ on Stack Overflow

values from a foreach loop in a function into an array

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related