Combining two functions for working with an array of objects

Question

I have two arrays of objects.

const details = [
    {
        ciphertext: 1234,
        buyer: {
            op_timezone: 7689,
            op_city: 'Name1',
        },
        assignment_info: { 
            info: {
                end_data: 1456,
                start_date: 2389,
            }
        }
    },
    {
        ciphertext: 5678,
        buyer: {
            op_timezone: 4568,
            op_city: 'Name2',
        },
        assignment_info: { 
            info: {
                end_data: 3467,
                start_date: 8753,
            }
        }
    },
];

const jobIds = [
    {
        id: 1,
    },
    {
        id: 2,
    },
];

I need to combine two arrays and take the assignment_info.info and buyer fields from each object.

function getDetailsBuyersWithJobIds(jobIds, details) {
    return jobIds.map((item, index) => ({
        ...item,
        ...details[index].buyer,
    }));
};

function getDetailsAssignmentInfosWithJobIds(jobIds, details) {
    return jobIds.map((item, index) => ({
        ...item,
        ...details[index].assignment_info.info,
    }));
};

The question is, how can two functions be combined into one?

That there would be no duplicate function, since they perform the same thing.

Can you just add ...details[index].assignment_info.info, as the 3rd line of the object in the first function? — CertainPerformance
– CertainPerformance, Commented Sep 3, 2019 at 7:02
you can pass third argument stating you want 'getDetailsBuyersWithJobIds' or 'getDetailsAssignmentInfosWithJobIds' and just do condition there — Tapan Dave
– Tapan Dave, Commented Sep 3, 2019 at 7:06
@CertainPerformance I can, but the problem is that at the moment I'm taking two fields from the object, there will be more in the future — MegaRoks
– MegaRoks, Commented Sep 3, 2019 at 7:06
I guess you could pass getDetailsAssignmentInfosWithJobIds the callback used with .map (though that also makes getDetailsAssignmentInfosWithJobIds itself nearly useless) — CertainPerformance
– CertainPerformance, Commented Sep 3, 2019 at 7:08

sjahan · Accepted Answer · 2019-09-03 07:12:48Z

2

You can do a generic mapping function and pass it a getter function that will be able to fetch the proper data, not sure it will help the global readibility though.

What do you think about that?

const genericMapper = (getter) => (item, index) => ({
    ...item,
    ...getter(details[index]),
});

function getDetailsBuyersWithJobIds(jobIds, details) {
    return jobIds.map(genericMapper(it => it.buyer));
};

function getDetailsAssignmentInfosWithJobIds(jobIds, details) {
    return jobIds.map(genericMapper(it => it.assignment_info.info));
};

const details = [
    {
        ciphertext: 1234,
        buyer: {
            op_timezone: 7689,
            op_city: 'Name1',
        },
        assignment_info: { 
            info: {
                end_data: 1456,
                start_date: 2389,
            }
        }
    },
    {
        ciphertext: 5678,
        buyer: {
            op_timezone: 4568,
            op_city: 'Name2',
        },
        assignment_info: { 
            info: {
                end_data: 3467,
                start_date: 8753,
            }
        }
    },
];

const jobIds = [
    {
        id: 1,
    },
    {
        id: 2,
    },
];

console.log(getDetailsBuyersWithJobIds(jobIds, details));
console.log(getDetailsAssignmentInfosWithJobIds(jobIds, details));

answered Sep 3, 2019 at 7:12

sjahan

5,9804 gold badges24 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

MegaRoks Over a year ago

I think this is better than rewriting a function

Code Maniac · Accepted Answer · 2019-09-03 07:12:44Z

You can add values on return object based on condition something like this

const details = [{ciphertext: 1234,buyer: {op_timezone: 7689,op_city: 'Name1',},assignment_info: {info: {end_data: 1456,start_date: 2389,}}},{ciphertext: 5678,buyer: {op_timezone: 4568,op_city: 'Name2',},assignment_info: {info: {end_data: 3467,start_date: 8753,}}},];

const jobIds = [{id: 1,},{id: 2,},];

function getDetails(jobIds, details, props = {
  getBuyer: true
}) {
  return jobIds.map((item, index) => ({
    ...item,
    ...(props.getBuyer && { ...details[index].buyer
    }),
    ...(props.getAssignment && { ...details[index].assignment_info.info
    })
  }));
};


console.log(getDetails([1], details, {
  getBuyer: true
}))
console.log(getDetails([1], details, {
  getAssignment: true
}))

Here props = { getBuyer: true} used to set a default value.

Collectives™ on Stack Overflow

Combining two functions for working with an array of objects

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related