disconnecting from a socket in java

Question

Hi i am building a little p2p program, implementing both the server-side and the client-side. when I lunch the client-side program, first think it does is to connect to each server in its list, send data (about the client-side) and disconnect. The next time the client-side connects to one of these servers it will be recognized.

My problem - when i tell the client-side to disconnect, i get this exception

java.io.EOFException
at java.io.DataInputStream.readUnsignedShort(Unknown Source)
at java.io.DataInputStream.readUTF(Unknown Source)
at java.io.DataInputStream.readUTF(Unknown Source)
at oop.ex3.nameserver.NameServerThread.run(NameServerThread.java:24)

to disconnect i just wrote:

 finally {
        out.close();
        in.close();
        socket.close();
    }

so, how do i avoid this exception? thanks!

Uhh, have you thought about what would happen if any of the individual close() statements throw an exception? — luis.espinal
– luis.espinal, Commented Apr 26, 2011 at 16:59

Liv · Accepted Answer · 2011-04-26 16:57:22Z

11

The JavaDoc for Socket.close() states clearly:

Closing this socket will also close the socket's InputStream and OutputStream.

which will throw the exception since you've already closed them!

answered Apr 26, 2011 at 16:57

Liv

6,1541 gold badge24 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Peter Lawrey · Accepted Answer · 2011-04-26 17:21:31Z

0

When you close the client side, what would you expect to happen on the server side?

To avoid this exception, you need to implement you own readUnsignedShort() method like.

public int readUnsignedShort() {
   int ch1 = in.read();
   int ch2 = in.read();
   if ((ch1 | ch2) < 0)
//     don't throw new EOFException(); 
       return -1; // EOF marker.

   return (ch1 << 8) + (ch2 << 0);
}

answered Apr 26, 2011 at 17:21

Peter Lawrey

535k83 gold badges770 silver badges1.2k bronze badges

Comments

giorgiline · Accepted Answer · 2012-10-06 15:08:08Z

0

Would it be right doing a flush before closing the output streams?:

finally {
    //this is the DataOutputStream
    if(dout != null){
        dout.flush();
        dout.close();
    }
    //and this the OutputStream
    if(out != null){
        out.flush();
        out.close();
    }
    if (din != null){
        din.close();
    }
    if (in != null){
        in.close();
    }
    if (socket != null){
        socket.close();
    }
}

edited Oct 6, 2012 at 15:08

answered Oct 6, 2012 at 14:34

giorgiline

1,3816 gold badges23 silver badges36 bronze badges

Collectives™ on Stack Overflow

disconnecting from a socket in java

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related