Script prints the name of the variable instead of its value

Question

I'm using this script that takes an url and modifies it. It stores the new URL in a variable called #url and then it sets that variable as the href of a link.

It's changing the HREF however instead of printing the URL it's creating a link to the name of the variable: #url

This is the script:

    if(url.match(/http:\/\//))
    {
    url = url.substring(7);
    }
    if(url.match(/^www\./))
    {
    url = url.substring(4);
    }
    url = "www.chusmix.com/tests/?ref=" + url;
    $("#output").html(url);
    $("#url").val(url).focus().select();
    var yourElement = document.getElementById('test');
 yourElement.setAttribute('href', '#url');

I'm trying to make it work in JSFiddle, I just tried chaning the quotes but didn't work.

http://jsfiddle.net/Lisandro/JKxRg/4/

Thanks for any help

try removing your single quotes. the quotes are making it a string and not a call to the var. — jhanifen
– jhanifen, Commented Apr 27, 2011 at 5:07
I just tried without them on the variable and without them and with double quotes and neither did work =S — lisovaccaro
– lisovaccaro, Commented Apr 27, 2011 at 5:12

jhanifen · Accepted Answer · 2011-04-27 05:09:11Z

1

Remove the single quotes and no need to update the val if you going to change the attribute later.

 yourElement.setAttribute('href', url);

answered Apr 27, 2011 at 5:09

jhanifen

4,5978 gold badges46 silver badges69 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Cyril Gupta · Accepted Answer · 2011-04-27 05:17:42Z

0

yourElement.setAttribute('href', '#url');

'#url'?

You're printing a literal, so why are you surprised when you see a literal. jhanifen has given you the correct answer.

answered Apr 27, 2011 at 5:17

Cyril Gupta

13.8k11 gold badges70 silver badges92 bronze badges

1 Comment

lisovaccaro Over a year ago

I have no idea how to use js it's my first site using it that's why. not mad. just telling

Collectives™ on Stack Overflow

Script prints the name of the variable instead of its value

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related