How to send sort using dropdown

Question

I have a problem with sorting some data in my page. Here is the snippet:

<form name=frm action="" method="post" style="display: inherit;">
    <label>
       Эрэмбэ:
       <select class="input-select" name="qryorder" onchange="document.frm.submit()">
          <option value="asc">Price ascending</option>
          <option value="desc">Price descending</option>
       </select>
    </label>
</form>

Here is the data i want to sort:

Code snippet:

 <?php
    if(isset($_POST['qryorder'])) {
        $sort = $_POST['qryorder'];
        sort_by_price($sort);
        // header('Location: product.php');
    }
?>

And my function:

  function sort_by_price($sort)
{
    global $conn;

    $sql = "select * from product order by price = '{$sort}'";
    $result = $conn->query($sql);

    $list = array();

    while ($row = $result->fetch_assoc()) {
        $list[] = $row;
    }
    return $list;
}

What i exactly want is i need to sort some data ordered by price ascending and descending.

what is data you want to sort? Please explain more your issue. — Au Nguyen
– Au Nguyen, Commented Sep 22, 2019 at 5:24
I edit my question i want to sort that datas as price ascending and descending with select option — batgerel.e
– batgerel.e, Commented Sep 22, 2019 at 5:32
Show us your php code, bcz that it the one which does this sorting by altering mysql query. In MySQL query you have to change order by clause. — Dark Knight
– Dark Knight, Commented Sep 22, 2019 at 5:44
You really shouldn't be doing the sorting this way. Your code is vulnerable to SQL injection. Use whitelist. stackoverflow.com/a/60496/1839439 — Dharman
– Dharman ♦, Commented Sep 22, 2019 at 8:33

Dark Knight · Accepted Answer · 2019-09-22 07:57:13Z

1

Don't use = operator in you order by clause.

Reference: Sorting Rows

$sql = "select * from product order by price $sort";

Updated Code: Price field in table was VARCHAR which was causing incorrect sorting, converted into BIGINT.

edited Sep 22, 2019 at 7:57

answered Sep 22, 2019 at 5:52

Dark Knight

6,6211 gold badge22 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

batgerel.e Over a year ago

Fatal error: Uncaught Error: Call to a member function fetch_assoc() on bool in G:\development\tgnm\includes\functions.php:334 Stack trace: #0 G:\development\tgnm\product.php(5): sort_by_price('desc') #1 {main} thrown in G:\development\tgnm\includes\functions.php on line 334

Dark Knight Over a year ago

check my updated answer, I forget to remove curly braces.

Dark Knight Over a year ago

ctrl + f5 and then try changing sorting from dropdown

batgerel.e Over a year ago

i cannot loading my page.

Collectives™ on Stack Overflow

How to send sort using dropdown

1 Answer 1

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related