Implement subroutine for repeating code in macro

Question

I am wondering is there any way to shorten my current code. I am running one process in a lot of my macros and was thinking about subroutine. I have tried several approaches but can't get it work.

I am performing one search several times:

Sub AddFileToDC()

    '... I am getting oDCSearchConditions from the search, then

    ' Execute the search
    Dim oDCObjectSearchResults As MFilesAPI.ObjectSearchResults
    Set oDCObjectSearchResults = oVault.ObjectSearchOperations.SearchForObjectsByConditions(oDCSearchConditions, MFSearchFlagNone, False)

    ' Get a reference to the existing document collection
    Set oDocumentCollectionOVAP = oVault.ObjectOperations.GetObjectVersionAndProperties(oDCObjectSearchResults.Item(1).ObjVer)

    Set oOldDocumentOVAP = oVault.ObjectOperations.GetObjectVersionAndProperties(oObjectSearchResults.Item(1).ObjVer)

End Sub

In all other macros I am performing another search from where I get oObjectSearchResults.

Instead of copying code above to all my macros, is it possible to do something like:

Sub Code1()

    '... I am getting oSearchConditions from the search, then

        ' Execute the search
        Dim oObjectSearchResults As MFilesAPI.ObjectSearchResults
        Set oObjectSearchResults = oVault.ObjectSearchOperations.SearchForObjectsByConditions(oSearchConditions, MFSearchFlagNone, False)

    AddFileToDC

End Sub

Now while running Code1 I am getting error message saying variable oDCObjectSearchResults not defined as it is in another sub AddFileToDC...

You can't have the same variable name in both sets of code as the memory is already allocated for that specific variable name; your call for the macro AddFileToDC needs to have the dimensioning/setting removed for that variable being dimensioned/set in Code1. You will most likely need to dimension the variable globally so both subroutines can utilize it. — Cyril
– Cyril, Commented Sep 25, 2019 at 15:44

Cyril · Accepted Answer · 2019-09-25 15:47:28Z

1

Making your like-named variable a global variable, while removing the setting/dimensioning from the called macro after you have set the variable:

Public oObjectSearchResults As MFilesAPI.ObjectSearchResults

Sub Code1()

        ' Execute the search
        Set oObjectSearchResults = oVault.ObjectSearchOperations.SearchForObjectsByConditions(oSearchConditions, MFSearchFlagNone, False)

    AddFileToDC

End Sub

Sub AddFileToDC()

    ' Get a reference to the existing document collection
    Set oDocumentCollectionOVAP = oVault.ObjectOperations.GetObjectVersionAndProperties(oDCObjectSearchResults.Item(1).ObjVer)

    Set oOldDocumentOVAP = oVault.ObjectOperations.GetObjectVersionAndProperties(oObjectSearchResults.Item(1).ObjVer)

End Sub

answered Sep 25, 2019 at 15:47

Cyril

6,8291 gold badge21 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Implement subroutine for repeating code in macro

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related