How to efficiently repeat a block of PHP code including a loop?

Question

I would like to repeat the following code 15 times or more on a single page:

$html .= '<select name="select_product_category" 
class="dropdown_list"><option value="0">All 
categories</option>';

foreach($categories as $value)  {

$html .= '<option value="' . $value['category_id'] . 
'"';

if($value['category_id'] === $active_category_id) 
$html .= ' checked';

$html .= '>' . $value['category_name'] . '</option>';

}

$html .= '</select>';

Is there a better way to achieve this than just repeat this particular block of code? Thanks for your support.

Multiple times in different places? You could create a function. — Don't Panic
– Don't Panic, Commented Sep 27, 2019 at 18:27
A function seems to be the best option indeed. Thanks @Don't Panic — Durian Nangka
– Durian Nangka, Commented Sep 28, 2019 at 6:29

Pavol Velky · Accepted Answer · 2019-09-27 18:38:28Z

1

Try to use functions as suggested by @Don't Panic

<?php

    function generateSelectBoxHTML() 
    {
        $html = '<select name="select_product_category" class="dropdown_list"><option value="0">All categories</option>';
        foreach ($categories as $category) {
            $checked = '';
            if ($category['category_id'] === $activeCategoryId) {       
                $checked = ' checked="checked"';
            }

            $html .= sprintf('<option value="%s"%s>%s</option>', $category['category_id'], $checked, $category['category_name']);
        }

        $html .= '</select>';
        return $html;
    }

    $html .= generateSelectBoxHTML();
    // ...
    $html .= generateSelectBoxHTML();
    $html .= generateSelectBoxHTML();
    $html .= generateSelectBoxHTML();

answered Sep 27, 2019 at 18:38

Pavol Velky

8305 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How to efficiently repeat a block of PHP code including a loop?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related