issue with map (data structure) in this code

Question

var str = "abhishekkeshri"
var arr = str.split("")
var myMap = new Map();
console.log(arr)
//alert(arr)
var n = arr.length;
for (let i = 0; i < n; i++) {
  var count = 0;
  for (let j = i + 1; j < n; j++) {
    if (arr[i] === arr[j]) {
      count++;
      console.log("inside loop " + arr[i] + " " + count)

    }
    myMap.set(arr[i], count);
  }

}

myMap.forEach((key, value) => {
  console.log(key + " " + value)
})

This is my code: I am trying to check the count of each alphabet in a string a storing the data on the map. But my Output is not the expected one. Can you point out my mistake? Also if there is any other better and optimized way to do please let me know

P.S. attaching my output

output of the code:image

taking out the counts of no of occurance of eachalphbets in the string, like h is 3 times, i is 2 times a is 1 time. — Ayushi Keshri
– Ayushi Keshri, Commented Oct 2, 2019 at 7:19

Nina Scholz · Accepted Answer · 2019-10-02 07:02:54Z

4

You could get the count from the map or zero and set the map to an incremented count without using an inner loop.

var str = "abhishekkeshri"
var arr = str.split("")
var myMap = new Map();
var n = arr.length;
for (let i = 0; i < n; i++) {
  let count = myMap.get(arr[i]) || 0; // get count from map or take zero as default value
  myMap.set(arr[i], count + 1);       // add one for the actual character
}

myMap.forEach((value, key) => {       // switch key/value
  console.log(key + " " + value)
})

answered Oct 2, 2019 at 7:02

Nina Scholz

388k26 gold badges367 silver badges417 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ayushi Keshri Over a year ago

this is the best solution i can get. Thanks for making it this easy.

Collectives™ on Stack Overflow

issue with map (data structure) in this code

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related