Combining two lists in Haskell

Question

NOTE: prohibited from using ++ in your code.

join :: ([t],[t]) -> [t]

which takes a pair of lists of some type t, (xs,ys) and returns a single list that contains all the elements some testcases :

join ([],[])) "==" [])
join ([],[5,6,5])) "==" [5,6,5]
join ([7],[5,6,5])) "==" [7,5,6,5]
join ([3,7],[5,6,5])) "==" [3,7,5,6,5]
join ("be","happy")) "==" "behappy"

This is what I currently have

module Sum where 
join :: ([t],[t]) -> [t]
join x y = [ z | z <- x, a <- y]

the error I get is

Sum.hs:3:1: error:
    * Couldn't match expected type `[t]'
                  with actual type `[t0] -> [a0]'
    * The equation(s) for `join' have two arguments,
      but its type `([t], [t]) -> [t]' has only one
    * Relevant bindings include
        join :: ([t], [t]) -> [t] (bound at Sum.hs:3:1)
  |
3 | join x y = [ z | z <- x, a <- y]
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Sum.hs:3:23: error:
    * Couldn't match expected type `[a0]' with actual type `([t], [t])'
    * In the expression: x
      In a stmt of a list comprehension: z <- x
      In the expression: [z | z <- x, a <- y]
    * Relevant bindings include
        x :: ([t], [t]) (bound at Sum.hs:3:6)
        join :: ([t], [t]) -> [t] (bound at Sum.hs:3:1)
  |
3 | join x y = [ z | z <- x, a <- y]
  |                       ^

developer_hatch · Accepted Answer · 2019-10-07 02:18:39Z

5

First of all, you have a type error in the arguments of the function:

join :: ([t],[t]) -> [t]
join x y = [ z | z <- x, a <- y]

it should be:

join :: ([t],[t]) -> [t]
join (x,y) = [ z | z <- x, a <- y]

but that will return to you:

  join' ("hello", "world")
=> "hhhhheeeeellllllllllooooo"

because list comprehension combines all values from the two lists, so, don't use it in this case. Instead:

Why don't you use recursion over the structure of (,) and []? it should be easy as:

join :: ([a], [a]) -> [a]
join ([], ys) = ys
join (xs, []) = xs
join ((x:xs), ys) = x : (join (xs, ys))

example:

join ("hello", "world")
=> "helloworld"

edited Oct 7, 2019 at 2:18

answered Oct 7, 2019 at 1:57

developer_hatch

16.3k3 gold badges47 silver badges79 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dan D. · Accepted Answer · 2019-10-07 02:00:30Z

1

They want you to implement ++.

If you could use ++, the implementation would be:

join (x, y) = x ++ y

answered Oct 7, 2019 at 2:00

Dan D.

75k15 gold badges111 silver badges129 bronze badges

1 Comment

Dan D. Over a year ago

I saw that before the edit which is why I wrote the answer the way I did.

Collectives™ on Stack Overflow

Combining two lists in Haskell

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related